Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Streaming Issue (no HKSV) #549

Closed
wants to merge 2 commits into from
Closed

[Bug]: Streaming Issue (no HKSV) #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c7970
do it once not twice
lenoxys Apr 18, 2024
5bce25b
[Bug]: Streaming Issue (no HKSV)
lenoxys Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugin/controller/LocalLivestreamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class LocalLivestreamManager extends EventEmitter {

this.log.debug(station.getName() + ' station livestream (P2P session) for ' + device.getName() + ' has started.');
this.livestreamStartedAt = Date.now();
const createdAt = Date.now();
const createdAt = this.livestreamStartedAt;
this.stationStream = { station, device, metadata, videostream, audiostream, createdAt };
this.log.debug('Stream metadata: ' + JSON.stringify(this.stationStream.metadata));

Expand Down
1 change: 1 addition & 0 deletions src/plugin/controller/streamingDelegate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ export class StreamingDelegate implements CameraStreamingDelegate {
activeSession.audioProcess.start();
}

this.log.warn('Talkback: ', this.camera.cameraConfig.talkback);
if (this.camera.cameraConfig.talkback) {
const talkbackParameters = await FFmpegParameters.forAudio(this.videoConfig.debug);
await talkbackParameters.setTalkbackInput(sessionInfo!);
Expand Down
10 changes: 7 additions & 3 deletions src/plugin/utils/ffmpeg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
StartStreamRequest,
} from 'homebridge';
import { SessionInfo } from '../controller/streamingDelegate';
import { ffmpegLogger } from './utils';
import { ffmpegLogger, log } from './utils';
import { reservePorts } from '@homebridge/camera-utils';

class FFmpegProgress extends EventEmitter {
Expand Down Expand Up @@ -488,13 +488,17 @@ export class FFmpegParameters {
}
server.close();

socket.on('error', () => { }); // ignore since this is handled elsewhere
socket.on('error', (error) => {
log.debug('Talkback Socket', error);
}); // ignore since this is handled elsewhere

socket.end(sdpInput);
});
server.listen(port);

server.on('error', () => { }); // ignore since this is handled elsewhere
server.on('error', (error) => {
log.debug('Talkback Server', error);
}); // ignore since this is handled elsewhere

killTimeout = setTimeout(() => {
server.close();
Expand Down