Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optionally reload plugins #1174

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

BethanyBerkowitz
Copy link
Contributor

Status

READY

Description

Part of #1163

This PR allows a plugin to use an option reloadOnConfigure to be reloaded whenever configure() is called, rather than just once.

Currently no plugins use this feature, but we plan to use this functionality in the server-side js package's unhandledRejection and uncaughtException plugins.

Todos

  • Tests
    - Documentation The __plugins option appears to be undocumented (ie it does not appear here, so I don't think this change requires documentation.

Steps to Test or Reproduce

npm run test

@BethanyBerkowitz BethanyBerkowitz merged commit 0f4698e into master Sep 6, 2023
@BethanyBerkowitz BethanyBerkowitz deleted the BKB/reload-plugin branch September 6, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants