forked from woowacourse/java-racingcar-precourse
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[자동차 경주 게임] 이태순 미션 제출합니다. #2
Open
LTSGOD
wants to merge
30
commits into
hongik-dev-mentoring:main
Choose a base branch
from
LTSGOD:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove carPos, carNum - change dynamic array -> ArrayList
- cars array -> List array, comfortable to input - change other method implementation
- after a round, set position 0
- add carBase property not to use setPostiion - delete 0 code in getPostion Because of Sort
- delete import List - add SortCar method - add HashMap Scoreboard, setScoreboard method, Score method
- Because of using sorted method remove all ScoreBoard method - add sorted method to maintain order of cars - add SortedCars property
- to record number of win, add winNumProperty - add getter, setter of winNum
- add // explain position Base
- after TryNum Round, it calculate who is the whinner
- 몇몇 메소드들 public -> private 전환 - 콘솔 입력 받는 부분 코드 단순화
- handlingRoundCoWinner, handlingFinalCoWinner 메서드로 분리 - 일부 public 접근 함수 private으로 접근권한 변환
- 멤버변수에 final 키워드 추가 - for 문 단순화
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.