refactor exception handling to close #23 #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@micha please review -- there might be additional cases i failed to take into account in this fix. i don't recall what the originally-intended purpose of the
ex
fns was, but they seem unnecessary now. currently left for compatibility reasons, but should we remove them entirely - are they considered part of the public api?https://github.com/jumblerg/castra/blob/master/src/castra/core.clj#L16-L18
similarly, should we also dissoc
status
,message
,stack
andcase
fromex
? also preserved for backwards compatibility in this commit.https://github.com/jumblerg/castra/blob/master/src/castra/core.cljs#L42