Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor exception handling to close #23 #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jumblerg
Copy link
Member

@micha please review -- there might be additional cases i failed to take into account in this fix. i don't recall what the originally-intended purpose of the ex fns was, but they seem unnecessary now. currently left for compatibility reasons, but should we remove them entirely - are they considered part of the public api?

https://github.com/jumblerg/castra/blob/master/src/castra/core.clj#L16-L18

similarly, should we also dissoc status, message, stack and case from ex? also preserved for backwards compatibility in this commit.

https://github.com/jumblerg/castra/blob/master/src/castra/core.cljs#L42

@jumblerg
Copy link
Member Author

jumblerg commented Dec 20, 2016

i also find it quite annoying that, during development, certain classes of errors are propagated up to the client while others appear in the server console; could/should errors being handled by castra still be logged to the console in some fashion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant