Fix undefined variable middleware #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fucked up with git, original PR (#137) was closed 🤦
This PR fixes #136
Problem comes from the fact that in the test suite, we are using Laravel's exception handler wich will hide some issues. If in their projet the developer uses withoutExceptionHandling, they can face Spectator bug (in this case returning an undefined variable).
I decided to fix this issue extracting PathItem resolution from actual request/response validation.
I would also suggest to run the entire test suite without exception handling (except required ones like ValidationException or HttpException) in order to prevent such issues to be hidden again. I can send a follow-up PR if you want.
Finally, not sur if this PR should be sent to master or develop branch. @hotmeteor please tell me if I should send it to develop, I will rebase my branch and change that