Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v2 #178

Merged
merged 9 commits into from
Mar 15, 2024
Merged

Prepare v2 #178

merged 9 commits into from
Mar 15, 2024

Conversation

bastien-phi
Copy link
Collaborator

Adds a composer alias for v2 and upgrade guide.

It might need to be completed

@bastien-phi bastien-phi added this to the V2 milestone Jan 29, 2024
@bastien-phi bastien-phi marked this pull request as draft January 29, 2024 20:22
@jarrodparkes
Copy link
Collaborator

@bastien-phi aside from updating docs, what else are you and @hotmeteor desiring for v2?

@hotmeteor
Copy link
Owner

I think @bastien-phi has knocked out almost every single issue, which is amazing.

I'm going to chip away at some docs cleanup this morning. I don't think it needs to be enormous, but maybe just ensure it's clear what exactly this package handles, OpenAPI versioning, etc.

@bastien-phi
Copy link
Collaborator Author

I think it's possible to fix #140 before v2 but I did not have a lot of time recently because of client work.

I think I will get some time next week to push a couple of PRs. This would make v2 almost ready.

@hotmeteor
Copy link
Owner

@bastien-phi Right on

I've updated the README in this branch a little. If you have a minute, can you drop in this thread:

  • any new methods you're aware of
  • any new configs you're aware of
  • any behaviors that have changed in v2

Basically anything you can think of that _might_be counter to what the docs did say.

I can take it from there, but you are much closer to all the nuances of the changes.

@bastien-phi
Copy link
Collaborator Author

@hotmeteor I think I already covered everything in the upgrade guide. I'll take a look on that but everything should be up-to-date

@bastien-phi
Copy link
Collaborator Author

@hotmeteor I may be wrong but Spectator::reset is not documented

@bastien-phi bastien-phi marked this pull request as ready for review March 15, 2024 07:34
@bastien-phi
Copy link
Collaborator Author

I think we are close from V2. @jarrodparkes can you take a look on this ? Merging this will pre-release the V2 thanks to the composer alias.

@hotmeteor I will let you hit the release button when you want !

Copy link
Collaborator

@jarrodparkes jarrodparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made a small change for a typo I noticed

@bastien-phi
Copy link
Collaborator Author

Thanks @jarrodparkes !

@bastien-phi bastien-phi merged commit cfde0e8 into master Mar 15, 2024
8 checks passed
@bastien-phi bastien-phi deleted the prepare-v2 branch March 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants