Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new geometry creation workflow #2156

Merged
merged 17 commits into from
Feb 27, 2025
Merged

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Feb 6, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

Update new feature creation workflow:

  1. create an entity in ODK of a newly created feature
  2. create a geom record
  3. then pass entity uuid to ODK intent URL as a param

Screenshots

image
image

@NSUWAL123 NSUWAL123 marked this pull request as ready for review February 27, 2025 07:54
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a styling difference in our IDE config that makes this PR hard to review πŸ˜…
(added whitespace?)

Looks good otherwise!

@spwoodcock spwoodcock merged commit 21c7d1d into development Feb 27, 2025
6 checks passed
@spwoodcock spwoodcock deleted the feat/entity-creation branch February 27, 2025 22:33
@NSUWAL123
Copy link
Contributor Author

I think we have a styling difference in our IDE config that makes this PR hard to review πŸ˜… (added whitespace?)

Looks good otherwise!

It seems that the .prettierrc config isn't working on the mapper frontend. Need to look into this why it's not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants