Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change user role to org admin in user list endpoint #2238

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

  • Previously, the project admin role was used to fetch the users list, thinking that one project admin can add another project admin but during project creation we won't have project id to check if the user is project admin or not since to create project they need to be org admin

Describe this PR

  • Update role dependency to org_admin in backend to fetch users list
  • Passed org id as a query param from frontend

Screenshots

N/A

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock February 28, 2025 12:12
@Sujanadh Sujanadh self-assigned this Feb 28, 2025
@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code backend Related to backend code labels Feb 28, 2025
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need both the capability to access all users on FMTM (admin only), plus also users per project (project manager) I think?

So either we need a separate endpoint for these cases, or we need another way to handle this with one endpoint.

I don't think this change will work for both πŸ˜…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants