Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move server detection out of the configuration flag #35

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Move server detection out of the configuration flag #35

merged 1 commit into from
Dec 20, 2024

Conversation

jorgemanrubia
Copy link
Member

Setting the enabled config option to true shouldn't enable hotwire spark in other processes.

@jorgemanrubia
Copy link
Member Author

cc @jacob-carlborg-apoex

jacob-carlborg-apoex
jacob-carlborg-apoex approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jacob-carlborg-apoex jacob-carlborg-apoex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgemanrubia jorgemanrubia merged commit adb851d into main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-carlborg-apoex jacob-carlborg-apoex jacob-carlborg-apoex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgemanrubia @jacob-carlborg-apoex