Skip dispatching messages if Turbo is not loaded #77
Conversation
There was a problem hiding this comment.
You have edited the build output of rollup instead of the original source files. To properly adapt your patch you should add your changes to the originalmonitoring_channel.js async received() method and run npm run build to compile the files. Your patch should contain all changes (the build output and your original changes).
| @@ -1600,6 +1600,10 @@ var HotwireSpark = (function () { | |||
| document.body.setAttribute("data-hotwire-spark-ready", ""); | |||
| }, | |||
| async received(message) { | |||
| if (!window.Turbo) { | |||
| log(`Turbo not detected, skipping ${message.action}`); | |||
There was a problem hiding this comment.
I think Turbo is only required if you're using the :replace method. The :morph variant should not require window.Turbo to be available. Could you check if your app is using the :replace or :morph variant?
I think this check should live in the html_replace_reloader.js to avoid skipping messages for all other reloaders.
| @@ -1600,6 +1600,10 @@ var HotwireSpark = (function () { | |||
| document.body.setAttribute("data-hotwire-spark-ready", ""); | |||
| }, | |||
| async received(message) { | |||
| if (!window.Turbo) { | |||
| log(`Turbo not detected, skipping ${message.action}`); | |||
| return; | |||
There was a problem hiding this comment.
This would hide errors for apps without Turbo and silently not update the page by default. I think a better approach here would be to always log a descriptive error with an explanation on how to avoid the error, e.g. [hotwire-spark] Tried to replace the page with Turbo, but Turbo is not available on window.Turbo or sth. similar :)
Spark raises errors on pages where Turbo is not loaded. We now check to see if Turbo is loaded before trying to action on the messages.
My Use Case
I have a Rails app where I am using Turbo on the majority of pages, but specific pages are using React. Spark raises errors in my JS console when I am on those React pages.
Considerations
I wasn't sure if this should be a
console.logto warn people or use the internal log function. I went with the internal log so that it wouldn't be noisy for people who know what they are doing. However I could see this as being confusing for first time users who maybe don't have Turbo loaded and don't understand why it isn't working.