Merge pull request #93 from stimulusjs/stable-has-target-property-names

Fix inconsistent has*Target property names in different locales
hotwired · Feb 2, 2018 · bb0b3d0 · bb0b3d0
2 parents 2212fb6 + 2847986
commit bb0b3d0
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/karma.conf.js b/karma.conf.js
@@ -58,6 +58,14 @@ if (process.env.CI) {
       browserName: "chrome",
       version: "63"
     },
+    sl_chrome_lang_tl: {
+      base: "SauceLabs",
+      browserName: "chrome",
+      version: "63",
+      chromeOptions: {
+        args: ["--lang=tr"]
+      }
+    },
     sl_firefox_43: {
       base: "SauceLabs",
       browserName: "firefox",

diff --git a/packages/@stimulus/core/src/target_properties.ts b/packages/@stimulus/core/src/target_properties.ts
@@ -57,5 +57,5 @@ function defineLinkedProperties(object: any, properties: PropertyDescriptorMap)
 }
 
 function capitalize(name: string) {
-  return name.charAt(0).toLocaleUpperCase() + name.slice(1)
+  return name.charAt(0).toUpperCase() + name.slice(1)
 }
diff --git a/packages/@stimulus/core/test/cases/target_tests.ts b/packages/@stimulus/core/test/cases/target_tests.ts
@@ -11,6 +11,7 @@ export default class TargetTests extends TargetControllerTestCase {
       <div data-controller="${this.identifier}" id="child">
         <div data-target="${this.identifier}.delta" id="delta1"></div>
       </div>
+      <textarea data-target="${this.identifier}.input" id="input1"></textarea>
     </div>
   `
 
@@ -60,4 +61,8 @@ export default class TargetTests extends TargetControllerTestCase {
     this.assert.equal(this.controller.betaTargets.length, 0)
     this.assert.throws(() => this.controller.betaTarget)
   }
+
+  "test has*Target property names are not localized"() {
+    this.assert.equal(this.controller.hasInputTarget, true)
+  }
 }
diff --git a/packages/@stimulus/core/test/target_controller.ts b/packages/@stimulus/core/test/target_controller.ts
@@ -9,9 +9,13 @@ export class BaseTargetController extends Controller {
 }
 
 export class TargetController extends BaseTargetController {
-  static targets = [ "beta" ]
+  static targets = [ "beta", "input" ]
 
   betaTarget: Element | null
   betaTargets: Element[]
   hasBetaTarget: boolean
+
+  inputTarget: Element | null
+  inputTargets: Element[]
+  hasInputTarget: boolean
 }