-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to work with Chapel 2.0, quiet some linter warnings #25
Conversation
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
The delta is used in this section, and tmp is used in the next section. Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
The output in the examples seems to assume 0-based boundaries, so this change makes the boundaries zero. Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. It should be safe to Approve and Run the workflows that need maintainer approval. |
Thank you, Daniel! Please give me a couple of days to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @DanilaFe -- all looks good, after a couple of very small corrections. Merging into the main branch.
Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
Auto-generated via `{sandpaper}` Source : c4c051d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-18 19:45:44 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 2f919b9 Branch : main Author : Alex Razoumov <[email protected]> Time : 2024-11-18 19:44:12 +0000 Message : Merge pull request #25 from DanilaFe/update-for-new-chapel Update code to work with Chapel 2.0, quiet some linter warnings
This PR is best reviewed commit-by-commit.
The main goal was to fix the Chapel code in the examples that no longer works under Chapel 2.0. Some notable changes fixed by this PR:
dmapped
keyword now requiresnew
, and the distributions are calledblockDist
andcyclicDist
instead ofBlock
andCyclic
isfull()
method on sync variables is nowisFull
(a property)imode
is nowioMode
exp
requiresuse Math
atomic real >= real
comparison is no longer supported, so use.read()
This PR also fixes a number of small typos and bugs (omitted variables, incorrect names (
T
vstemp
), etc.The most significant linter-specific change is that
do
is not necessary in loops with{
:do
is for single-statement loops,{
is for loops with multiple statements.Also, some of the output seems to expect non-
25
boundary conditions, whereas it sets up with25
boundary conditions. This PR changes the boundaries to0
for that portion of the code, so that the output of the program matches the expected output.