Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#32100] Customize bash_run and bash_compile. Add support for multi cluster options #12

Merged
merged 8 commits into from
Jul 2, 2024
Merged

[#32100] Customize bash_run and bash_compile. Add support for multi cluster options #12

merged 8 commits into from
Jul 2, 2024

Conversation

RohithSurya
Copy link
Collaborator

Fixes #32100

Type of change: Feature

Description

  • Make bash_run and bash_compile configurable
  • Allow to specify multiple clusters for WorkUnitSubmit
  • Add project file structure to contributing md
  • Add documentation on how to run tests for users

Checklist

  • Did I make sure I wrote the tests if I have implemented new functionality?
  • Did I make sure the test coverage meets the guidelines specified in CONTRIBUTING.md?
  • Did I lint and format the code?

@github-actions GitHub Actions
Copy link

Hi @RohithSurya, thank you for your interest in contributing to PyHPCC!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@RohithSurya RohithSurya changed the title [#32100] Customize bash_run and bash_compile. Add support for multi cluster options WIP: [#32100] Customize bash_run and bash_compile. Add support for multi cluster options Jun 26, 2024
@RohithSurya RohithSurya changed the title WIP: [#32100] Customize bash_run and bash_compile. Add support for multi cluster options [#32100] Customize bash_run and bash_compile. Add support for multi cluster options Jul 1, 2024
amila-desilva
amila-desilva approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@amila-desilva amila-desilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Rohith! Thanks for implementing

@amila-desilva amila-desilva merged commit e66075b into hpcc-systems:main Jul 2, 2024
amila-desilva added a commit that referenced this pull request Sep 9, 2024
@amila-desilva
Merge pull request #12 from RohithSurya/features/32100-config_run_com…
43f4d0f 
…pile

[#32100] Customize bash_run and bash_compile. Add support for multi cluster options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amila-desilva amila-desilva amila-desilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohithSurya @amila-desilva