Rewrite the tick loop system #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern tick loop was implemented, is useless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest rewrites the tickloop system.
Previously, we used a patch that backported the modern tick loop, but several things were not working correctly/missing in the backport version (we can say that basically most of the things that use IAsyncHandler, ReetrantIAsyncHandler, TaskPerTick or the classes depended on it), like it would take a lot of time to port the modern tick loop correctly, understand how it works, etc.) I decided to backport the tickloop system from Minecraft 1.13 adapted with appropriate changes for Spigot and Paper (In essence, the system is basically the same as the modern tick loop, but with everything working).
-- Another thing I noticed was that the previous patch had changes in threads that had nothing to do with the modern tick loop itself but with changes from Mojang, this is an irrelevant curiosity but I decided to comment.
This system has been tested on at least 3 servers, no problems were found.