Stable release for 2019 (#277)

[timgarrels]

• add squeak5-2 CI target and allow trunk to fail

• add develop travis batch to readme

• Wrap IMAP Credentials into asterixs' for propper IMAP compliance (see RFC 3501 chapter 4.3)

• Emphasize LoadOlderMail ist Email list (fixes "load older eMails" should look like a button #168)

• Make Endpoint use IMAP conform Strings

• Change two hardcoded dictionary keys, which where supposed to be the same

• Use theme-defined color for "load older eMails" should look like a button #168 fix

• Relocate load-older-emails-button emphasize filter to separate method

• Made AuthInfo Object only accept IMAP convertible strings

• Added template coverage badge from coveralls

• coveralls

• added coverage icon

• added coverage config to ston

• Updated Coverage badge to show develop

• Fixed bad double click fix, added good double click api call

• $o opens selected Email

• Refactored emailListKeyPressMapping

• Fix typo

• Configure coverage only for Core package

• Added install to call Menu Entry Added

• update readme

• Removed class method and refactored emailListKeyPress:

• Renamed and recategorized methods in ICEmail and made one triggle down change in ICFolder because of rename of uid -> uniqueID

• Refactor/rename get methods (Refactor/rename get methods #198)

• Renamed all get* method in Core

• Renamed get* methods in UI

• Renamed get* methods in Tests

• Added lazy init for body and header in ICEmail and removed initialize (Added lazy init for body and header in ICEmail and removed initialize #199)

• Adde lazy init for body and header in ICEmail and removed initialize

• Feature/release building (Feature/release building #206)

• Created sar export in test code

• Update .travis.yml

• Switched from seperate sars to one install sar

• Revert "Update .travis.yml"

• Feature/searchbar experience (Feature/searchbar experience #201)

• Change Search Bar Widget from InputText to TextField

• set setter and getter so the CR behavior is correct

• Implement check for account name existence in login dialog (Implement check for account name existence in login dialog #205)

• Implement check for account name existence in login dialog

• Improve semantics of method name

• Refactor duplicate finding

• Added Lazy init for ICEndPoint, ICFetchResponseParser, ICFolder, ICServerInfo, ICStreamWrapper, ICFolderDialog and ICLoginDialog

• Renamed all "anObject" parameters

• TDD: Added Tests for Connection Configuration storage in ICEndPoint

• Changed a* to an*

• Enter confirms password (enter confirms password #220)

• Implements Remove FileIO, store data inside image #212. Deleted file storage methods in ICHelper and removed their tests. Implemented image storage in ICEndPoint and changed occurences from ICHelper

• Tested validity check in ICEndpoint. This was already tested indirectly in the test for addConfiguration. This just removed the indirection.

• Split up ICFolderDialog build method

• Refactor ICFolderDialog build method

• Introduce navigation panel element into ICFolderView

• Travis can not handle asDictionary. Therefore changed to Dictionary newFrom:

• Moved methods from "as yet unclassified" to fitting categories (Moved methods from "as yet unclassified" to fitting categories #233)

• Split build method into multiple methods

• Fix empty fields checking and refactor to better naming (Fix empty fields checking and refactor to better naming #213)

• Fix empty fields checking and refactor to better naming

• Use higher level collection protocol methods

• Removed unused methods (Removed unused methods #235)

• Removed ICFolder lazy init.
  Reference to Added Lazy init #215 (review) and Added Lazy init #215 (comment)

• Removed ICLoadOlderMail from Core and added UI-Button which loads older emails

• Fix startup configuration (Fix startup configuration #246)

• Add account icon (Add account icon #247)

• Fixed bug which caused account to remove by adding copy (Fixed bug which caused account to remove by adding copy #238)

• Fixed bug which caused account to remove by adding copy

• Revert hacky fix

• Tested occurred bug, added bug fix

• Added Class Comments for all classes except the ServiceProvider in th… (Added Class Comments for all classes except the ServiceProvider in th… #248)

• Added Class Comments for all classes except the ServiceProvider in the UI and Test Packages

• Ottos Feedback on wording and spelling

• Use consistent wording for the description of an instance.

• Establish default settings for login dialog (Default (prefillled) values for login dialog #250)

• fixes Prefilled Account Registration Fields #223

• Copied parser methods from ICEndPoint to ICParser

Co-authored-by: Otto Kissig [email protected]

• Refactored the methods that have been relocated to ICParser

Co-authored-by: Otto Kissig [email protected]

• Add protocol package to smalltalkCI coverage measurement

Co-authored-by: Otto Kissig [email protected]

• Add protocol package to smalltalkCI coverage measurement

Co-authored-by: Otto Kissig [email protected]

• Redirected parse calls in endpoint to parser

Co-authored-by: Otto Kissig [email protected]

• Remove parser traces from ICEndPoint

Co-authored-by: Otto Kissig [email protected]

• Fixed small bug caused by typo

• Refactor/252 ICAccount info (Refactor/252 ICAccount info #254)

• Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course

• Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code

• Fixed renaming issue

• Removed unused method

• Removed unused method

• Renamed ICAccountInfo contructor (legacy artifact)

• Review Requests on Refactor/252 ICAccount info #254

• Recategorization and little code beautification

• name-attribut artifact replacement

• Made everything use anAccountINfo instead of Dictionary
  Made everything use 'accountName' instead of 'name'

• Fixed "Account edit"

• Fixed Test Defaults

• Refactor/218 date formatted test fix (Refactor/218 date formatted test fix #263)

• Added new tests. Made tests more specific

• Fixed second and date parsing

• Changed private method to travis accessible method

• Moved default subject responsibilities (Moved default subject responsibilities #264)

• Moved default subject responsibilities

• Code Standard

• Refactor/252 ic account info (Refactor/252 ic account info #266)

• Literally just merged ICAuthenticationInfo with ICServerInfo. Had to change constructors of course

• Reworked the endpoint login and connection system to work with the new AccountInfo Class. This caused a lot of change in the test code

• Fixed renaming issue

• Removed unused method

• Removed unused method

• Renamed ICAccountInfo contructor (legacy artifact)

• Review Requests on Refactor/252 ICAccount info #254

• Recategorization and little code beautification

• name-attribut artifact replacement

• Made everything use anAccountINfo instead of Dictionary
  Made everything use 'accountName' instead of 'name'

• Fixed "Account edit"

• Fixed Test Defaults

• 255 folder name attribute (255 folder name attribute #262)

• Made ICFolder use 'folderName' instead of 'name'

• Changed ToolBuilder textfield from 'name' to 'accountName'

• Typo fix

• Readme/removearchitecture (Readme/removearchitecture #267)

• remove architecture from readme.
  it's outdated and visible in the wiki

• add hint for people to look at the wiki to readme

• Moved Commands from EndPoint to ICCommand (Moved Commands from EndPoint to ICCommand #268)

• Added Command Methods to ICCommand

• Removed constants from ICCommand because they where dublicate in ICEndPoint

Co-authored-by: Felix Rindt [email protected]

• Refactored Methods in ICCommand and methods calls in ICEndPoint

Co-authored-by: Felix Rindt [email protected]

• Added class comment

(And minor code style refactoring I forgot the last time)

• Implemented required Changes

• More requested changes

Moving constants from EndPoint to Command, renamed Methods and recategorized

• Finalize ICParser extraction

• fixed broken tests

Co-authored-by: Otto Kissig [email protected]

• Copied ICResponseParser into ICParser

• Adapt calls and tests from ICFetchResponseParser to ICParser

Co-authored-by: Otto Kissig [email protected]

• Law of Demeter, Comment corrected, removed unused method (Law of Demeter, Comment corrected, removed unused method #270)

• "Das kann weg" - Patrick R. (Removed Service Provider #271)

• Requested Changes and removed unused methods

Co-authored-by: Otto Kissig [email protected]

• Remove ICHelper (Remove ICHelper #269)

• Removed unused method

• Refactor to use collect

• Made ICHelpers paramter sort method obsolete

• Changed child folder collection

• Moved hash function

• Moved EndPoint creation out of helper

• Removed ICHelper

• Pauls Feedback

• Moved hash test

• Made ICParser compatible with Travis Squeak Build Version

Co-authored-by: Otto Kissig [email protected]

• Fix test that was still using ICHelper

Co-authored-by: TIm Garrels [email protected]

• fix account delete

• Create tests for ICNullStream and ICStreamWrapper

Co-authored-by: Tim Garrels [email protected]

• Made ICFolderDialogs ICEndpoint usage more obvious (Made ICFolderDialogs ICEndpoint usage more obvious #275)

• Made Deployment modular

• Fixed whitespace assumption

• Added cover for Core Error in UI

• Replaced getter with converter

• UI Notes origin (UI Notes origin #282)

• Fixed whitespace assumption

• Added cover for Core Error in UI

• Switched "UIManager default" usage to usage of "self"

• Hotfix for rootfolder and context menu

• Fix 'Move to trash' Context Menu

• start refactoring to remove linter issues (start refactoring to remove linter issues #286)

• start refactoring to remove linter issues

• fix issues according to the review from @EightSQ

• Remove warning at 'Move to trash' (Remove warning at 'Move to trash' #287)

• Refactor the protocol package according to the lint (Refactor the protocol package according to the lint #290)

• start refactoring to remove linter issues

• fix issues according to the review from @EightSQ

• start linting the parser package

• First Lint batch (First UI Linting Batch #291)

• Second Lint UI Batch (Second Lint UI Batch  #294)

• First Lint batch

• Removed comments, replaced checks, shortened methods

• Felix' Feedback

• Refactor according to Linter in the Test Package (Refactor according to Linter in the Test Package #295)

• start refactoring to remove linter issues

• fix issues according to the review from @EightSQ

• Some core linting (Some core linting #292)

• Some core linting

• Fix linting mistakes

• fix EatingBacon's comments

• Refactor all linting issues in Protocol package (Refactor protocol package according to the linter (remaining issues) #298)

• Implemented handling of malicious mime headers (Implemented handling of malicious mime headers #299)

• Made long methodlines short and removes unnecessary comments (Made long methodlines short and removes unnecessary comments #302)

• Some core package linting (Some core package linting #301)

• Some core package linting

• Some more lint refactoring

• Remove left over method

• Remove some debug code

• Fixed lints as far as humanly possible (Fixed lints as far as humanly possible #305)

• Restore Travis Ci links [ci skip]

Co-authored-by: Felix Rindt [email protected]
Co-authored-by: Paul Methfessel [email protected]
Co-authored-by: Martin Taraz [email protected]
Co-authored-by: Tim Garrels [email protected]
Co-authored-by: EatingBacon [email protected]
Co-authored-by: justus.eilers [email protected]
Co-authored-by: paul.methfessel [email protected]
Co-authored-by: Felix Rindt [email protected]
Co-authored-by: Fabio Niephaus [email protected]