-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#176 add explicit Warning handler for onWarningLog ... allow older ve…
…rsions of Metacello to continue to be used
- Loading branch information
1 parent
74da09c
commit 2ad7502
Showing
4 changed files
with
31 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 25 additions & 12 deletions
37
...itory/SmalltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/basicLoadProjectOn..st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,27 @@ | ||
executing | ||
basicLoadProjectOn: aSmalltalkCI | ||
| metacello | | ||
aSmalltalkCI class requireMetacello. | ||
metacello := (Smalltalk at: #Metacello) new. | ||
self onWarningLog | ||
ifTrue: [ metacello onWarningLog ]. | ||
metacello | ||
repository: (self loadRepositoryFor: aSmalltalkCI); | ||
baseline: self baseline; | ||
configuration: self configuration; | ||
version: self version. | ||
metacello copy get. "compensate for older versions of Metacello" | ||
aSmalltalkCI performMetacelloLoad: [ metacello load: self load ] | ||
| metacello baseBlock loadBlock | | ||
aSmalltalkCI class requireMetacello. | ||
metacello := (Smalltalk at: #'Metacello') new. | ||
self onWarningLog | ||
ifTrue: [ metacello onWarningLog ]. | ||
metacello | ||
repository: (self loadRepositoryFor: aSmalltalkCI); | ||
baseline: self baseline; | ||
configuration: self configuration; | ||
version: self version. | ||
metacello copy get. "compensate for older versions of Metacello" | ||
baseBlock := [ metacello load: self load ]. | ||
loadBlock := self onWarningLog | ||
ifTrue: [ | ||
loadBlock := [ | ||
"compensate for older versions of Metacello" | ||
baseBlock | ||
on: Warning | ||
do: [ :ex | | ||
Transcript | ||
cr; | ||
show: ex description. | ||
ex resume ] ] ] | ||
ifFalse: [ baseBlock ]. | ||
aSmalltalkCI performMetacelloLoad: loadBlock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.