Make coverage filter less strict #667
Conversation
|
Looks very promising, thanks @Gabriel-Darbord. I'll review on the weekend. |
...malltalkCI-Coverage-Tests.package/SCICodeCoverageTest.class/instance/testFilterLegalNames.st
Show resolved
Hide resolved
|
@ClotildeToullec, @moosetechnology, any idea why that Moose build is suddenly failing? Looks to be a VM problem... |
I restarted the failed job and it failed again in the same way. Since we are touching the coverage infrastructure, maybe some method is instrumented that shouldn't be instrumented? |
|
The same build fails on main: https://github.com/hpi-swa/smalltalkCI/actions/runs/13616209541/job/38059615520?pr=668. It has to be something external. |
|
I've run most of the other failing builds manually. I'd say we merge. @fniephaus? |
|
I was about to suggest to mark Moose as allowed failures but it seems Pharo builds are failing too? |
|
Looks like the same VM issue. Not our problem really... |
|
I'm fine with merging this. It is a problem for smalltalkCI users and I hope someone is going to fix the VM issue. |
|
Can you take care of the release? There's still a prerelease from December. |
|
Good point, I just published https://github.com/hpi-swa/smalltalkCI/releases/tag/v3.0.7 |
This PR changes the implementation of class filtering for code coverage as described in #666 (see implementation explanation).