Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

237 quick fix use points once for polylines #242

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

elenagensch
Copy link
Contributor

quick fix for #237

  • seeds db for ci in order to check postgres with seeds
  • adjusts seeds for postgres

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
each points in the seeds point list are accessed, a new point is created
@elenagensch elenagensch requested a review from FranzSw January 31, 2022 16:58
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #242 (71a7277) into dev (7389543) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
+ Coverage   78.70%   78.91%   +0.21%     
==========================================
  Files          49       49              
  Lines         939      939              
==========================================
+ Hits          739      741       +2     
+ Misses        200      198       -2     
Impacted Files Coverage Δ
app/models/floor.rb 100.00% <0.00%> (+16.66%) ⬆️
app/models/point_of_interest.rb 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7389543...71a7277. Read the comment docs.

@elenagensch elenagensch self-assigned this Jan 31, 2022
Copy link
Contributor

@FranzSw FranzSw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One test was removed, which (if I'm correct) tests, that all polylines in the DB are returned. We could also replace the 0 with the new seeded value (14) instead of removing the test, but I'm not sure if it makes more sense.

@elenagensch
Copy link
Contributor Author

Looks good. One test was removed, which (if I'm correct) tests, that all polylines in the DB are returned. We could also replace the 0 with the new seeded value (14) instead of removing the test, but I'm not sure if it makes more sense.

True, however the local behaviour is different, at least with my setup (seeds do not affect the test), I prefer removing this test

@elenagensch elenagensch merged commit d1c7e47 into dev Feb 1, 2022
@elenagensch elenagensch deleted the 237-quick-fix-use-points-once-for-polylines branch February 1, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants