Skip to content

v11.0.5-1.0.7-CN

Compare
Choose a tag to compare
@github-actions github-actions released this 31 Oct 06:02
· 253 commits to thewarwithin since this release

Hekili

v11.0.5-1.0.7-CN (2024-10-31)

Full Changelog Previous Releases

  • 同步更新至v11.0.5-1.0.7

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Frost DK SimC update

  • Merge pull request Hekili#4115 from johnnylam88/feat/reserve-vanish-charges
    feat: add slider to reserve Vanish charges for rogues

  • Screenshot on manual snapshots

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Handle Demonic Healthstones

  • Merge pull request Hekili#4122 from syrifgit/syrif-hunter
    BM - no more multishot in ST

  • BM - no more multishot in ST
    hasn't been updated on the official APL yet, but this is no longer relevant due to multiple bug fixes

  • Merge pull request Hekili#4121 from syrifgit/syrif-rogue
    Sin rogue - carnage effect

  • Merge pull request Hekili#4120 from syrifgit/syrif-mage
    Arcane mage - Barrage Spam

  • Shadow: Improve Unfurling Darkness CD

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Arms, Ele, Fury sim updates

  • no reactions here

  • Sin rogue: Better APL support for no-target-swap users

  • Sin rogue
    old carnage handling for previous iteration of the effect

  • Update MageArcane.simc
    Replace react with up/down/stack

  • Arcane mage - fix barrage spam due to touch desync

  • Arcane pack string

  • feat: add slider to reserve Vanish charges for rogues
    Fixes Hekili#3855.

  • Merge pull request Hekili#4113 from johnnylam88/fix/bonestorm-bone-shield
    fix: Bone Shield stacks return zero during Bonestorm

  • fix: add correct events and times for Bone Shield gains during Bonestorm
    Fix an off-by-one error for the correct tick times for adding stacks to
    the Bone Shield, and also use the correct function QueueAuraEvent to
    queue the tick event.

  • fix: correct 2nd argument to removeStack
    The second argument to removeStack should be the number of stacks of
    the aura to remove, which is contained in consume.

  • Unbreak my Ret

  • Frost Reaper's Mark

  • Reimplement Bladestorm delay

  • Balance: Fix Eclipse and Touch the Cosmos and dream_Burst

  • Fix [FEATURE] The highlight feature does not work correctly when using NDui's action bars. Hekili#4096

  • Fix [BUG] Fury: No bloodbath during Ravager/Bladestorm w Unhinged Hekili#4098

  • Enhancement fixes

  • Shadow updates

  • Ret efficiency update

  • Fix Treacherous Transmitter not recommended in AoE Hekili#4102

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Frost Mage SimC update

  • Marksman: Sim update

  • Merge pull request Hekili#4106 from syrifgit/boomkin
    Boomkin

  • Fix [REC] Blood rotation should consume Reaper of Souls procs (Deathbringer) Hekili#4103

  • Fix [REC] Can't track strength of the black ox Hekili#4107

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Venga update

  • Bladestorm

  • Demonology: Overhaul Ritual/Art

  • Scent of blood fixes

  • English

  • final touches

  • bone spikes

  • Merge pull request Hekili#4093 from johnnylam88/fix/sanlayn-hero-talents

  • Merge pull request Hekili#4095 from syrifgit/boomkin

  • fix: remove unnecessary assignment
    vampiric\_strike is already copied from heart\_strike, so setting
    class.abilities[433895] to match heart\_strike is unnecessary.

  • Boomy moonfire readytime

  • Deathmark Sin Rogue Only
    (organizational only)

  • rupture
    more oopsies fixed. Don't remove rupture dots by accident.

  • Sin Rogue
    Add new dots before applying scent of blood agility buff

  • Moonfire usage
    fixes moonfire during treants

  • Review Notes Implemented

  • Rupture cleanup

  • Sin Rogue
    Significantly less dumb loop

  • Resolve upstream conflicts

  • Boomy, Frost Mage, Sin Rogue

  • Merge branch 'Hekili:thewarwithin' into boomkin

  • Revert "Boomkin, Frost Mage, Sin Rogue"

  • Boomkin, Frost Mage, Sin Rogue

  • fix: Empower Rune Weapon is a frost-only talent
    Remove Empower Rune Weapon references for blood and unholy death knights
    as it is a Frost-only talent since 11.0 (TWW).

  • fix: improve San'layn hero talents for blood death knight

  • fix: apply Infliction of Sorrow after Gift of the San'layn expires

  • fix: Essence of the Blood Queen stacks up to 5 (+2)

  • Arcane sim update

  • Revise channel chains and interrupts

  • Shadow SC/VT and Rechecks

  • Enhancement Voltaic Blaze

  • Assassin priority tweak tweak

  • Assassin: Improve consistency with SimC

  • Fix Hekili#4091

  • Merge pull request Hekili#4084 from bjth/thewarwithin
    Fix max stacks for IT, with the Dark Talons Hero Talent change

  • Merge pull request Hekili#4085 from syrifgit/syrif-fixes
    frost: action.flurry

  • Fix formatting. To be inline with the rest of the codebase

  • frost: action.flurry
    auto-importer fix maybe?
    action.flurry.cooldown -> cooldown.flurry

  • Fix max stacks for IT, with the Dark Talons Hero Talent change

  • Fix Defile talent

  • Merge pull request Hekili#4082 from syrifgit/syrif-fixes
    Sub & Frost pack regen

  • Merge branch 'thewarwithin' into syrif-fixes

  • Sub & Frost pack regen

  • Adjust dot tracking (for Prescience, maybe)

  • BM, Frost Mage updates

  • Merge pull request Hekili#4071 from syrifgit/syrif-fixes
    sub rogue APL is Finnish

  • Merge pull request Hekili#4079 from syrifgit/boomkin
    Boomkin updates without emojis 💢

  • Update PriestShadow.lua
    balance prio in shadow module?

  • Merge branch 'thewarwithin' into boomkin

  • More Balance

  • Fix Prot HoW

  • Merge branch 'thewarwithin' into boomkin

  • sync apl changes with hek

  • Balance priority update, fixes

  • Enhancement priority and Totemic stuff

  • Review notes
    ready to ship as-is for short term improvements

  • wrong branch

  • review notes implemented

  • Boomkin Update

    • fix wrath model
    • fix starfire model
    • start fixing treants model
    • APL edits to match sim behaviour (regrowth fix, moonfire fix)
      Lots more to do
  • Merge branch 'Hekili:thewarwithin' into syrif-fixes

  • revert adrenaline rush stealth break
    bug has been fixed

  • let Ret pals cast HoW during crusade

  • BDK
    fixes Hekili#4068

  • Arcane APL update
    Fix logic error with Arcane Tempo buff that was causing inappropriate barrages

  • BM Hunter APL update

  • Unholy: Update and expedite priority

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Assassin fixes, simc updates

  • Clear pmultipliers on reset

  • sub rogue APL
    sync with simc

  • Merge pull request Hekili#4066 from syrifgit/syrif-fixes
    Outlaw Polish

  • final version of safenum

  • Outlaw - Review
    Implement review notes

  • Outlaw RTB
    Fixes Hekili#4067 - tested by user
    no more comparing booleans to numbers

  • Outlaw Polish

  • Merge pull request Hekili#4062 from syrifgit/syrif-fixes
    Frost mage is ready to go

  • Merge pull request Hekili#4053 from Yuuseki/fix-assa-inevitabile_end
    fix(assassination): rename talent inevitable_end to inevitabile_end

  • Frost mag
    Accompanying pack string, remove unneeded variable, allow pet freeze to be cast while casting

  • Frost Mage
    Review notes implemented, actions.aoe reworked as per discussion with Frost Mage Theorycrafter. Added comment for the flurry time<0.2 so it doesn't get left behind again. All reacts are replaced with the appropriate buff or cd checks.

  • fix(assassination): add inevitable_end to talent table instead of renaming

  • Merge pull request Hekili#4052 from Yuuseki/fix-rogue-effective_combo_points
    fix(rogue): effective_combo_points evaluated correctly when at 0 CP

  • Merge pull request Hekili#4055 from Alandovos/thewarwithin
    Fix typo in Enhancement AOE APL

  • Sunfire doesn't require Moonkin Form

  • Frost mage is ready to go
    Beating dummy sims with both hero trees

  • Merge pull request Hekili#4054 from bjth/resto-shaman
    [REC] Restoration Shaman not working - Hekili#4051

  • Merge pull request Hekili#4046 from IIeTpoc/thewarwithin
    RtB superchaged handler was multiplicated

  • Fix typo in Enhancement AOE APL

  • [REC] Restoration Shaman not working - Hekili#4051
    Fixes - Hekili#4051

  • fix(assassination): rename talent inevitable_end to inevitabile_end

  • fix(rogue): effective_combo_points evaluated correctly when at 0 CP

  • Huntery fixery

  • RtB superchaged handler was multiplicated
    We already have superchaged_combo_points handle for Roll the Bones starting from line 1243. This one is duplicated i guess

  • Enhancement priority

  • Make Doom Winds a minor CD instead of major CD

  • Fix Hekili#4044

  • Fury: No bloodbath during Ravager/Bladestorm w Unhinged

  • Merge pull request Hekili#4041 from syrifgit/syrif-fixes
    Arcane Update

  • Fix Hekili#3969

  • Fix Hekili#3990 (probs)

  • Outlaw priority update and Rogue combo points fixes

  • Arcane Update
    Solid accuracy update, confirmed against Porom's WA for barrages. Arcane ready to go! Transcribed newest APL.

  • Elemental: fix Farseer, Ascendance, stuff

  • Unholy SimC update

  • Frost DK Soul Reaper fix plus SimC update

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Demo variable hardcoding

  • Merge pull request Hekili#4036 from bjth/thewarwithin
    [REC] Windwalker Monk not reccomending major cooldowns (Invoke Xuen and SEF)

  • Update MonkWindwalker.lua
    Include the copy of " invoke_xuen " from the original file before it was made MistWeaver

  • Update MonkWindwalker.lua
    Apply extra parameter for hero talents

  • Update MonkWindwalker.lua
    Fix formatting and include PvP Talents

  • Update MonkWindwalker.lua
    Update PvP Skeleton talents

  • Update MonkWindwalker.lua
    Update the Talents to the latest Skeleton.

  • Update MonkWindwalker.lua
    Apply Hero Talent Changes

  • Revert MonkWindwalker.lua
    Revert changes that copied MW over the top of WW

  • Enhancement: single priority updates

  • Shadow: Unfurling Darkness CD can be directly detected now

  • Enhancement: fix pwave

  • Remove diffs

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Paladin updates and in-game talent validation

  • Merge pull request Hekili#4025 from syrifgit/rogue-final-touches
    Sub rogues can play the game I guess

  • Sub rogues can play the game I guess

  • Unholy and Balance priority updates plus fix astral_communion buff

  • Merge pull request Hekili#4022 from syrifgit/rogue-final-touches
    More rogue stuff

  • Fix [REC] Augmentation spams azure strike and never uses living flame Hekili#4020

  • cringe Fix Hekili#4023

  • Fix Hekili#4021

  • Update RogueAssassination.lua
    forgot 1 part of the setting

  • More fixes

  • Enhancement: ice_strike_passive

  • Mistweaver weaves mists

  • Update RogueSubtlety.lua

  • Jadefire Empowerment stacks

  • Brewmaster and Windwalker in-game talent validation

  • Enhancement voltaic_surge and flowing_spirits fixes

  • Mage in-game talent validation and Arcane priority fix

  • Fury: fix talents and priority

  • Outlaw: Remove BtE bug workaround

  • Merge pull request Hekili#4016 from Hekili/11.0.5
    Merge 11.0.5 to main

  • Merge branch 'thewarwithin' into 11.0.5

  • Hunter in-game talent validation

  • Restore incarnation aliases

  • Merge pull request Hekili#4006 from syrifgit/syrif-fixes
    quick fixes, non-anniversary

  • Evoker in-game talent validation and updates

  • Merge pull request Hekili#4014 from syrifgit/rogue-final-touches
    Rogue final touches

  • Druid in-game talent validation and Balance/Feral priorities

  • for real
    stop doing math on booleans

  • Stop doing math on booleans

  • Demon Hunter in-game talent validation

  • final reviews

  • DK in-game talent validation and Frost/Unholy priority updates

  • Update RogueAssassination.lua
    regen sin pack

  • Sync /w Heks talent validation

  • Update RogueSubtlety.simc

  • Update RogueOutlaw.simc

  • Update RogueAssassination.simc

  • Update RogueSubtlety.lua

  • Update RogueOutlaw.lua

  • Update RogueAssassination.lua

  • Fire: Fix applyBuff

  • Merge branch '11.0.5' of https://github.com/Hekili/hekili into 11.0.5

  • Fire Mage: Probably fix Hekili#3978

  • Merge pull request Hekili#3997 from syrifgit/Rogue-Anniversary-Rework
    11.0.5 Reworks: Rogue

  • Merge branch '11.0.5' into Rogue-Anniversary-Rework

  • Priest in-game talent validation w Shadow priority update

  • Rogue in-game talent validation

  • Fury priority update

  • Warlock talent ID in-game validation

  • Enhancement : Flowing Spirits

  • Fury: (Sort of) fix Bloodthirst crit setting

  • Warrior talent ID in-game validation

  • Elemental, Enhancement in-game talent validation

  • Merge pull request Hekili#4009 from syrifgit/mage-anniversary-rework
    Mage Anniversary Rework

  • review

  • review notes

  • dont do math on booleans

  • pack strings and a survival type

  • Merge branch 'Rogue-Anniversary-Rework' of https://github.com/syrifgit/syrif-hekili into Rogue-Anniversary-Rework

  • Supercharged review implementation
    buff name stuff

  • Merge branch '11.0.5' into Rogue-Anniversary-Rework

  • superchargers unite

  • Mage diff files implemented

  • Arcane, BM
    uncomment the grace period, arcane diff checked.

  • Mag Anniversary Rework

  • Merge pull request Hekili#4004 from syrifgit/It's-a-hunter-anniversary
    Hunter's 20th Anniversary

  • Update HunterBeastMastery.lua

  • boop

  • quick fixes, non-anniversary

  • BM Review

  • Review done

  • yay its the rogues anniversay
    happy anniversary

  • Hunter's 20th Anniversary
    or something like that

  • Fix Hekili#4003

  • Shadow: SimC handles Unfurling Darkness ICD as a CD buff now

  • Elemental talents and quick changes

  • Add Nerub'ar Palace interrupts (from PR; w/o caching changes)

  • Review Warrior, Warlock, 2/3 Shaman Talents

  • Share referernce diffs

  • Increment TOC

  • Fix Hekili#3985

  • Fix Immolation Aura during Meta

  • Fix Hekili#4000

  • 18 priority updates

  • Outlaw debug info

  • Outlaw more fix

  • Outlaw: Testfix for RtB

  • Rogue rework

  • Merge pull request Hekili#3986 from syrifgit/TWW-Live---Syrif-Changes
    Hunter, Mage, Lock, minor fixes

  • Merge pull request Hekili#3987 from syrifgit/UI-Changes
    General UI Changes

  • no rotations or specs here
    only priorities and specializations

  • Revisions to UI
    as requested/disussed

  • Revisions
    Will leave the shadow priest part out for now as it will take longer to fix.

  • spriest
    bugfix to voidheart update

  • Spriest - Entropic Rift
    Improve Entropic Rift calculations. Is is inherently linked to voidheart which is a real, trackable buff with an ID. So alias it with entropic rift and use voidheart for all calculations. Removes need for reset_precast calculating as well.
    void torrent refreshes the 8 second buff on every tick, and void blast extends it by a second each cast, up to a max of 3 seconds per window.

  • BM - Call of the Wild CDR
    More accurate modelling, and also the initial tick was incorrect because it summons 2 pets so you are granted a full charge of each.

  • wrong copy paste
    undo

  • BM - Call of the Wild CDR
    More accurate modelling, and also the initial tick was incorrect because it summons 2 pets so you are granted a full charge of each.

  • WarlockDestruction.lua
    funnel toggle logic

  • WarlockAffliction.lua
    funnel toggle logic

  • WarlockDestruction.simc
    fix funnel toggle logic

  • WarlockAffliction.simc
    fix funnel toggle logic

  • MageFrost.lua
    Shifting power cooldowns toggle by default

  • MageFire.lua
    shifting power CDs toggle by default

  • HunterSurvival.lua
    UI consistency

  • HunterMarksmanship.lua

  • HunterMarksmanship.lua
    UI Consistency

  • HunterBeastMastery.lua
    Improve UI consistency / sizing

  • UI Changes

  • General UI

    • Update target settings UI to better guide the user through making their selections

    • Separate pet-based detection from nameplate detection

    • Change wording of many options

    • Minor tweaks to size / order of options

    Actual targeting logic has not been modified yet, that will be a future PR.

    More UI Cleanup. Change "Core" to "Specialization Settings", label is more intuitive especially for English Second Language users. Stop using "normal" width and start using "1.5" width on stuff to create consistency, this is a parameter value you already use elsewhere, may as well stick with it.

  • Merge pull request Hekili#3968 from johnnylam88/refactor/expansion-items
    refactor: move expansion-specific items into their own modules

  • Merge pull request Hekili#3972 from johnnylam88/fix/protection-warrior-thunder-blast
    fix: adjust Thunder Blast for protection warrior

  • Merge pull request Hekili#3974 from johnnylam88/fix/sanlayn-vamp-blood
    fix: treat Vampiric Blood as a cooldown with San'layn Hero Talents

  • Merge pull request Hekili#3977 from Yuuseki/thewarwithin
    fix(assassination): get correct mutilate and ambush energy cost

  • Remember not to forget

  • VDH: CD Resets, Stuff

  • Blood: Model BS->BS stacks; correct BS max stack

  • Make Assassin's combo_points.deficit account for charged points

  • Marksman fixes (from Syrif's PR)

  • Stormbringer to Stormsurge

  • Updated PvP target dummy list.

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • fix(assassination): fix cheap shot energy calculation

  • fix(assassination): add goremaws_bite line back in (deleted accidentally)

  • fix(assassination): more energy cost corrections

  • fix(assassination): get correct mutilate and ambush energy cost based on talent

  • Merge pull request Hekili#3971 from johnnylam88/fix/kaheti-shadeweavers-emblem

  • fix: treat Vampiric Blood as a cooldown with San'layn Hero Talents

  • fix: correct the buff ID for Kaheti Shadeweaver's Dark Ritual
    Fixes Hekili#3967.

  • fix: adjust Thunder Blast for protection warrior
    Use the correct texture ID for Thunder Blast on protection warrior, and
    fix how the Thunder Blast buff is handled when casting both Thunder Clap
    and Thunder Blast.

  • fix: support Timewalking Wrathstone trinket in TWW
    Fixes Hekili#3956.

  • refactor: load new expansion-specific Items.lua files

  • refactor: split out expansion-specific items from Classes.lua
    Move expansion-specific trinkets and other items from Classes.lua into
    separate, expansion-specific Items.lua files.
    This is meant to make addtions or updates for Timewalking events easier.

  • Merge pull request Hekili#3865 from johnnylam88/fix/slayer-hero-talent
    fix: manage Marked for Execution debuff from Slayer's Strike

  • Merge branch 'thewarwithin' into fix/slayer-hero-talent

  • Update WarriorFury.lua
    max/min and debuff fix

  • Update WarriorArms.lua
    Fix max/min; marked_for_execution debuff

  • Balance and Guardian updates

  • Unholy SimC update

  • Frost DK: SimC update, tie BoS RP option to priority

  • Prot Pal update

  • Demo: Fix Soul Strike queue (caused actions to repeat)

  • Holy Pal: Revise Eternal Flame (does not replace WoG)

  • BrM update 3

  • BrM: another update

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • BrM updates

  • Merge pull request Hekili#3929 from joshjau/arms-warrior
    Refactor Arms Warrior APL: Remove raid events, fix typo

  • Merge pull request Hekili#3935 from johnnylam88/fix/monk-brewmaster-tier-bonus
    fix: add buffs from monk brewmaster tier set bonuses

  • fix: adjust Keg Smash cost due to Flow of Battle

  • fix: add buffs from monk brewmaster tier set bonuses
    Add Flow of Battle buffs from the Monk Brewmaster tier set bonuses. The
    buffs are named identically to the ones used by SimulationCraft.

  • Fix projectile fix

  • Update WarriorArms.simc

  • Refactor Fury Warrior APL: Remove raid events, simplify fight conditions
    Updated heroic leap and variable checks to use in-game observable conditions instead of raid events for better real-world applicability.

  • Demo: Light's Judgment lol

  • Assume every projectile spell lasts at least 0.25 seconds and don't break everything maybe

  • Blood: Exterminate fallback outside DRW

  • UH use UA more in AOE

  • Fix Hekili#3903 (probably)

  • Shadow: Multiple Tickets

  • Assassin: Darkest Night, filler to max CP (fix Hekili#3913)

  • Sub: Don't break Stealth with Gear-a-Rang

  • Fix Hekili#3911

  • Apply Templar fix to Protection Paladin

  • Updates and fixes for Balance, Aug, Frost Mage, Shadow, Sub, Fury

  • Merge pull request Hekili#3923 from syrifgit/thewarwithin
    UI Enhancements

  • UI Improvement - Snapshots

  • Low-Level Warning
    Increase threshold from under level 50 to under level 70

  • Merge pull request Hekili#3909 from syrifgit/thewarwithin
    Sin Rogue - Rupture Opener

  • Fix rogue pack string

  • Marksmanship
    correct the CDR trueshot applies to rapid fire and aimed shot for the currently active AS/RF cooldown.

  • Sin Rogue - Rupture Opener
    Allow users to leave target swapping turned off without borking the entire 4+ target opener.
    This condition change allows rupture to cast on the same target twice when called from the stealth list, which will max out your scent of blood buff due to the rupture talent which spreads it to other targets.

  • Merge pull request Hekili#3888 from johnnylam88/feat/fade-on-wait
    feat: fade on wait

  • feat: option to desaturate icons on cooldown as if out of range
    Add a toggle to desaturate the primary icon if you should wait past the
    GCD or natural cooldown before using the ability, similar to when an
    ability is out of range.
    Addresses Hekili#3552.

  • Unholy priority update

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Augmentation Prescience and FB

  • feat: only fade if the recommended ability can't be spam-cast
    When the recommended ability can't be spam-cast because it requires
    waiting past the end of the GCD or the current spellcast, then fade the
    ability as unusable if the appropriate setting is toggled.
    Remove a commented code block that is a duplicate of code in the "delay"
    check as we directly re-use the value that is stored in
    b.EarliestTime.

  • refactor: rename variable for more clarity in what it stores
    Rename local variable moment to earliest\_time to better document
    what it actually holds, and store the value in the display's first
    button in the field EarliestTime.
    No functional change intended.

  • refactor: move range/usability check later in "OnUpdate"
    Move the range and usability check in OnUpdate to later in the
    function so that it can re-use some computations made in earlier checks.
    No functional change intended.

  • refactor: rescope a local variable to avoid potential aliasing
    No functional change intended.

  • Merge pull request Hekili#3874 from johnnylam88/feat/filter-spell-reflection
    feat: allow limiting the use of Spell Reflection on warriors

  • More Ret LD

  • Enhancement tweaks

  • Another one

  • And again

  • feat: change how M+ interruptible spells are handled
    Instead of removing the casting debuff from the target if the spell
    doesn't matches the M+ interrupt filter, change the casting debuff to
    signal that the spell is not interruptible. This allows priorities to
    still react to the spellcast with other abilities besides an interrupt
    ability.

  • feat: allow limiting the use of Spell Reflection on warriors
    Create a toggle to limit Spell Reflection to be usable only on
    reflectable spells from TWW Season 1 dungeons that are targeting the
    player.
    Store the database of reflectable spells in Hekili.Class for warriors
    only as it is warrior-specific.

  • Merge pull request Hekili#3878 from syrifgit/thewarwithin
    Aspect of the Eagle is baseline now

  • Merge pull request Hekili#3886 from xinni/patch-1
    Enhancement: Tempest summon Feral Spirit

  • Fix Hekili#3858

  • Fix Hekili#3887

  • Fix Hekili#3882: Shadowmoon Insignia added (though defensive)

  • Fix Hekili#3885: registered trinkets will work even if not usable

  • Fix Elysian Decree vs. Sigil of Spite

  • Testfix for Hekili#3856

  • Sigil of Spite IDs (Fix Hekili#3889)

  • Ret HoL test alpha

  • Enhancement: Tempest summon Feral Spirit
    Should fix the issue descriped in Hekili#3871

  • HoL fix (maybe)

  • Fix HoL debug again

  • More HoL debug

  • Fix HoL debugging :|

  • Add HoL debugging info

  • Import Balance Starfall fix

  • Update DruidBalance.simc
    Fix Starsurge in AOE

  • Aspect of the Eagle is baseline now

  • fix Light's Deliverance stacks

  • WW Xuen fix

  • Havoc Immolation Aura ID (for keybind)

  • Assassin fix fix

  • Frost DK Unleashed Frenzy

  • Blood Marrowrend w Exterminate

  • Balance priority update

  • Augdate upmentation

  • Arcane and Fire updates

  • MW Teachings of the Monastery

  • WW priority update

  • Ret HoL?

  • Assassination priority fix?

  • Fix extra_amount action arg.

  • Enhancement: Tempest stacks to 2

  • Testfix: Light's Deliverance / HoL

  • MW: Teachings of the Monastery

  • Merge pull request Hekili#3873 from syrifgit/thewarwithin
    Enhance Pack String, all 3 shaman specs swiftness fixes

  • Enh natures swiftness

  • Nature's Swiftness and Ancestral Swiftness Fixes
    These buffs were triggering their cooldown on spellcast due to the onRemove function of the aura.
    Adding a check to only remove buff if buff is up fixes this behaviour.

  • Merge pull request Hekili#3864 from johnnylam88/fix/warrior-victory-rush-health
    fix: use correct expression name for victory\_rush\_health\_pct

  • Enhance pack string outdated?

  • Merge pull request Hekili#3872 from syrifgit/thewarwithin
    Unholy, Elemental fixes

  • Elemental Lightning Rod Fix
    Lightning Bolt & Chain only apply the debuff in Enhancement spec, not Elemental

  • Unholy DK APL Fix
    Typo cause vamp strike fishing list to not be called ever

  • fix: manage Marked for Execution debuff from Slayer's Strike
    Modify Arms and Fury warrior modules to manage the Marked for Execution
    stacking debuff from Slayer's Strike.
    Marked For Execution is applied by Slayer's Strike and stacks a maximum of
    three times and is removed only when Execute is cast.
    With the Imminent Demise talent, consuming Sudden Death applies Imminent
    Demise and stacks a maximum of three times and is removed by Bladestorm.
    Use the correct name for the debuff (also used in SimC) as
    marked\_for\_execution and allow it to be tracked via active\_dot.

  • chore: regenerate protection warrior action pack

  • fix: use correct expression name for victory\_rush\_health\_pct

  • Merge pull request Hekili#3860 from Spike2D/thewarwithin
    [Prot Warrior] - Spell Block added + Mitigation changes.

  • Spell Block added + Mitigation changes.

    • Settings for Spell Block added

    • Added Spell Block to SimC profile

    • Removed Solo modifier for mitigations and edited settings
  • Ruination quickfix

  • Demo and Destro updates, textures

  • Assassin priority tweak and option

  • Distinguish HoL free/ready

  • WW priority tweak

  • Frost Comet Storm

  • Aug priority work

  • Consuming Fire known ID

  • Merge pull request Hekili#3677 from johnnylam88/feat/caption
    feat: auto-import captions from APL profile

  • Merge pull request Hekili#3843 from johnnylam88/fix/monk-instant-vivify
    fix: properly account for Vivacious Vivification for monk

  • Merge pull request Hekili#3844 from johnnylam88/feat/refracting-aggression-module
    feat: add absorb buff from Refracting Aggression Module

  • Merge pull request Hekili#3846 from Spike2D/thewarwithin
    Trinket Foul fixed, Prot Warrior Mitigation fixed, and Prot Warrior unused setting removed.

  • Add files via upload

  • Add files via upload

  • More fixed to Victory Rush

  • Formatting of Victory Rush Setting

  • Victory Rush added to SimC

  • Victory Rush settings added, SimC updated.

  • Added updated profile

  • Removed last_stand_offensively

  • Foul Trinket ID Fixed

  • Fixed Prot Warrior Mitigations

  • Augmentation fixes

  • WW priority fix

  • feat: add absorb buff from Refracting Aggression Module
    Add the buff for the absorption shield that procs when you taunt with
    the Refracting Aggression Module tanking trinket.

  • fix: properly account for Vivacious Vivification for monk
    The Vivacious Vivification monk class talent makes the next Vivify
    instant and reduces its cost by 75%. Properly remove the buff when
    Vivify is cast and add functions for "cast" and "spend" to account for
    the buff.

  • Augmentation improvements to FB?

  • Vengeance priority adjustment for recheck timing

  • Fix hooks more.

  • Fix hooks.

  • More potion fix.

  • Fix the fixing fix

  • Prevent snapshot loops

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Fury priority update

  • Don't log talent errors before talents load

  • Subtlety update

  • Ret priority update

  • BrM, WW updates

  • Filter seasonal orbs

  • Merge pull request Hekili#3825 from zmsl/spec_setting_toggle
    Added WeakAura scan event for spec option toggling

  • Mage priority update

  • More potion fix

  • Merge branch 'Hekili:thewarwithin' into spec_setting_toggle

  • Fix Larynx

  • BM, Sv priority updates

  • Vengeance priority update

  • Fix potion fix

  • Potions and general fixes.

  • Added WeakAura scan event for spec option toggling

  • Resto Shaman tweak setting descriptions

  • Enhancement priority update

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Merge pull request Hekili#3813 from syrifgit/thewarwithin
    Arcane, Marksman

  • Aug and Dev priority updates

  • Druid priority updates

  • More error handling.

  • Handler logic

  • Unholy set bonus

  • Frost DK priority update

  • DK set bonuses.

  • Aimed Shot grants 2 charges of precise shots

  • implement review points

  • More error information when loading scripts

  • Yield before snapshotting to avoid script ran too long

  • Merge pull request Hekili#3820 from baaron666/patch-3
    Apply wildshape mastery buff when shifting from bear into cat

  • Apply wildshape mastery buff when shifting from bear into cat

  • Apply wildshape mastery buff if talented when shifting from bear into cat

  • feat: allow for textures in the caption string
    Allow for textures in the caption string if the texture ID is enclosed
    in square brackets, e.g., [461115] will get replaced by the texture for
    Rapid Fire in the caption string.

  • feat: extract a caption for an action from its comment
    In the APL profile, when pairing up a comment as the description for the
    action in the subsequent line, if the comment has the format
    ::
    then <Caption> is used as the caption for the action, and
    <Description> is used as the description for the action. Otherwise the
    comment is used unmodified as the description for the action.

  • feat: support multi-line comments in APLs
    In an APL profile, if a comment line is followed immediately by another
    comment line, then assume that they are part of the same comment and
    simply concatentate them together as the subsequent action's
    description.

  • feat: support a "caption" modifier in the action syntax
    Support a caption=... key-value modifier in the action syntax that
    works like the description=... modifier and allows for annotating an
    action with a caption.

  • Formatting

  • Marksmanship hunter
    Fix precise shots logic to reflect the game. Aimed shot grants 2 charges, and during trueshot with eagletalon talent, multi/arcane shot fire twice and it consumes both stacks.

  • Arcane, Marksman

  • Merge pull request Hekili#3792 from syrifgit/thewarwithin
    Restoration Shaman: Healing Helper Mode

  • Merge pull request Hekili#3789 from IIeTpoc/IIeTpoc-patch-4
    Stealth Padding return and Vanish, Adrenaline Rush "true" CD return

  • Update RogueOutlaw.lua
    Increment pack date

  • Merge pull request Hekili#3803 from zmsl/thewarwithin
    Adjusted Darting Hurricane GCD coefficient to match latest patch change

  • Fix Hekili#3802

  • Adjusted Darting Hurricane GCD coefficient to match latest patch change

  • Formatting

  • BM: Implement barbed_shot_grace_period internally and in priority

  • Fix Hekili#3753

  • Review implementation
    Finished except the talent descriptions, will add that later

  • Fix trinket ID

  • Fury PvP talent

  • Review implemented
    remaining TODO (do not commit yet):

    • healing rain duration
    • texture/name stuff in description
    • downpour ID
  • .simc file typo

  • Restoration Shaman
    Healing Helper Mode support + Second self-shield spec option

  • APL adjustments and Stealth Padding return
    Return Vanish and Adrenaline cd as "true" version

    Return Stealth Padding for Between the Eyes

  • Adjustments to APL and Stealth Padding
    Return Vanish and Adrenaline Rush cooldowns as "true".

    Return Stealth Padding for Between the Eyes

  • Fix Ice Lance cast vs. projectile

  • Merge pull request Hekili#3786 from syrifgit/thewarwithin
    Rsham, BM

  • Fix Hekili#3787

  • Add Mark of Khadros trinket

  • Drag the corpse of SpellFlash forward another few meters for Dominos support

  • Rsham, BM
    Groundwork for Restosham healing maintenance, Rsham preferred shield spec option groundwork (commented out until future PR), BM fix to stop "surprise" killshot in opener (it is not a surprise it's 100% guaranteed).

  • Recheck timing tweak

  • Iterate on Guardian

  • Improve Fury / integer resource rechecking

  • Fix Cold Blood

  • Merge pull request Hekili#3784 from johnnylam88/refactor/protwarr-settings
    refactor: push some addon settings into the priorities instead

  • Elemental priority and expressions update

  • Fire update

  • Marksman prioirty update

  • Roguery updates

  • Shadow Voidwrath Insanity generation

  • Aug and Dev priority updates

  • Balance update

  • Refine Unholy Sanlayn, update priority

  • Havoc update and merge Immo Aura with Cons Flame

  • Frost DK update

  • refactor: push some addon settings into the priorities instead
    Change some Protection Warrior settings so they are optionally checked
    within the priorities instead of directly in the abilities' usable
    functions. In particular, don't force the addon to enforce the settings
    for the following spells so the usage conditions can be set directly in
    the priorities:

    • Last Stand
    • Rallying Cry
    • Shield Wall
      Some of these settings made sense in previous expansions but
      current SimulationCraft profiles already try to take those extra
      conditions into account.
      Add new expressions that can be used in action modifiers:
    • last\_stand\_damage\_taken
    • last\_stand\_health\_pct
    • rallying\_cry\_damage\_taken
    • rallying\_cry\_health\_pct
    • shield\_wall\_damage\_taken
    • shield\_wall\_health\_pct
      Remove the settings that checked for "damage taken and health
      conditionals" as they can be individually checked within the priorities
      through the exposed expressions.
      No changes are made in the default protection warrior priority as Last
      Stand and Shield Wall are both used offensively in the default priority.
  • Fix Hekili#3777

  • Fix Blessing of Anshe / HoW

  • Trinkets

  • Merge pull request Hekili#3766 from johnnylam88/feat/snapshot-prev-spells
    feat: display previous spells in snapshot

  • feat: display previous spells in snapshot
    Show the previous spells (GCD and non-GCD) when saving a snapshot.
    This implements Hekili#3734.

  • Merge pull request Hekili#3765 from fwosar/update-interrupt-filter
    Update interrupt filter for TWW Season 1

  • Update UI

  • Update filter list

  • Merge pull request Hekili#3762 from syrifgit/thewarwithin
    Blessing of Anshe allows Hammer of Wrath to be cast on any target

  • Blessing of Anshe allows Hammer of Wrath to be cast on any target
    Fixes: Hekili#3760

  • Merge pull request Hekili#3757 from syrifgit/thewarwithin
    Resto Sham,Marksmanship cleanup

  • Vengeance Demonsurge

  • Havoc fixes

  • Implement review notes

  • More Ascendance buffs

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Fix Hekili#3756

  • Resto Sham,Marksmanship cleanup
    Misc minor changes

  • Merge pull request Hekili#3754 from syrifgit/thewarwithin
    Resto Shaman Down[our

  • Resto Shaman Down[our
    Downpour works with Surging Totem

  • Fix Hekili#3743

  • Fix Hekili#3707

  • Testfix for Prescience dots not fading

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Fix health, stagger rechecks

  • Merge pull request Hekili#3738 from syrifgit/thewarwithin
    Hunter Spec Option: Mend Pet

  • Hunter Spec Option: Mend Pet
    opt-in feature to specify a health % for your pet below which the addon will recommend mend pet, 0 by default (opted out).

  • Merge pull request Hekili#3733 from syrifgit/thewarwithin
    Arcane, BM

  • remove line_cd from arcane missile
    It's not needed anymore anyways, the prev.gcd conditions completely control the behaviour and make it match simc

  • Havoc: Demon Blades and Metamorphosis tweak

  • pack string

  • Merge branch 'Hekili:thewarwithin' into thewarwithin

  • Arcane, BM

    • Arcane Missile final solution (please)
    • BM polishing
    • Simplify barb/thrill/frenzy duration management
    • Implement prediction for CoTW barb and KC cooldown refund ticks
    • add skeleton for a mend pet spec option for solo play / world content / delves
  • Protection Warrior fix fix

  • Assassin, Sub updates and fixes

  • Recheck target.health.percent

  • Aff/Demo/Diabolist update

  • Recheck resource.pct

  • Protection Warrior fix?

  • Feral FB fix

  • Enhance / Ele TWW1

  • Arcane

  • MM priority update

  • DH TWW1 set

  • Demon Hunter priority updates

  • Fix Hekili#3727

  • Fix Hekili#3720

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Mess with Arcane

  • Fix line_cd

  • Merge pull request Hekili#3723 from johnnylam88/fix/warrior-settings
    fix: use Last Stand and Shield Wall Health Percentage correctly

  • fix: use Last Stand and Shield Wall Health Percentage correctly
    The Health settings for Last Stand and Shield Wall are compared directly
    with the current health percent in determining the whether the ability
    is usable. Don't rescale it by dividing by 100.

  • Merge pull request Hekili#3717 from syrifgit/thewarwithin
    Assorted Frost Mage improvements, Issue Report Template

  • Merge pull request Hekili#3721 from IIeTpoc/IIeTpoc-patch-3
    Enhancement Shaman update

  • Update ShamanEnhancement.lua

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • MM Wailing Arrow and priority update

  • SimC priority updates

  • Merge pull request Hekili#3718 from AmsTaFFix/fix_lifebloom
    fixed a lifebloom, which can not be founded in Keybinds

  • Include adjusted APL in default

  • Tempest buff max stack and Converging storm max stack

  • Enhancement APL adjustments
    After latest Hekili update an APL is missing some of SIMC changes.

  • Revert "Update Recommendation-Report.yml"

  • Update Recommendation-Report.yml

  • Testing new issue report form

  • fixed a lifebloom, which can not be founded in Keybinds

  • Assorted Frost Mage improvements
    Some polishing, correction to some mechanics.

    • Ice lance consumes fingers and applies cryopathy on cast, not impact
    • Ensure true pet duration
    • comment out old, removed talents
    • Casts only remove a stack of ice floes not the whole buff
    • Hailstones only has one rank
  • Augmentation fix

  • Frost DK priority update again

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Merge pull request Hekili#3711 from syrifgit/thewarwithin
    Guardian - Offensive Ironfur

  • Fix Hekili#3688

  • Guardian

  • Merge branch 'thewarwithin' of https://github.com/syrifgit/syrif-hekili into thewarwithin

  • Guardian - Barkskin duration
    Also fixed missing "and 0" from ironfur duration

  • Crackshot lock and BtE bugfix

  • Merge branch 'Hekili:thewarwithin' into thewarwithin

  • Merge branch 'thewarwithin' of https://github.com/syrifgit/syrif-hekili into thewarwithin

  • Guardian, allow offensive ironfur
    Also fixed the duration function, it was inaccurate.

  • Merge pull request Hekili#3708 from syrifgit/thewarwithin
    Survival Hunter Improvements

  • Update HunterSurvival.lua

  • Routine priority updates

  • Fix action.X.cooldown_react

  • Survival Hunter Improvements
    Revised version of @PoroKingWin's Tip of the Spear PR.
    Added better Bombardier handling for smoother rotation with less unexpected recommendation changes.

  • Fix Hekili#3646

  • Re-enable detailed variable debugging.

  • Fix Hekili#3666

  • Fix Hekili#3636

  • Merge pull request Hekili#3700 from IIeTpoc/thewarwithin
    Subterfuge duration calculation fix for RogueOutlaw.lua

  • Fix Hekili#3682

  • Fix Hekili#3696

  • Fix Hekili#3697 and Hekili#3698

  • Subterfuge duration calculation fix for RogueOutlaw.lua

  • Fix Hekili#3695

  • Fix Hekili#3691

  • Fix Hekili#3692

  • Fix Hekili#3685

  • Fix Hekili#3693

  • Fix Hekili#3689

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Priority updates from SimC

  • Merge pull request Hekili#3683 from syrifgit/thewarwithin
    Arcane, Ret, Shadow

  • Shadow Crash Opener
    No reason to have shadowcrash be reliant on a boss condition in precombat opener. In the SIMC apl it is simply "not dungeon slice". Having it show up in the AoE opener is natural and abides by the guides, as well as AoE sims.
    Fix for: Hekili#3644

  • Ret Pal: Blessing of Anshe spellID
    fix for Hekili#3627
    Ret was using the spellID for the Holy Version

  • More Arcane Tweaks
    Fix arcane orb check, remove rune of power (just like blizzard did), add lingering embers, make some talent checks smarter, stop removing arcane soul for no reason, remove some of the mana trickery (it's not all needed at max level)

  • Shadow: Distinguish VB from MB and tweak priority

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Fix Ravage

  • Merge pull request Hekili#3675 from ambonif/patch-5
    Fix Hekili#3641

  • Merge branch 'thewarwithin' into patch-5

  • Merge pull request Hekili#3678 from syrifgit/thewarwithin
    Significant Arcane Fixes

  • Significant Arcane Fixes
    Added many missing handlers, corrected buff/spell IDs, made up some hacky APL logic and mana trickery, but it now actually replicates the sim rotation reliably for the Sunfury spec.
    Any previous discussion can be seen on: Hekili#3669

  • Fix Hekili#3641
    Basically, the issue is that Magis Spark is not actually a buff applied to the player. The code originally references this https://www.wowhead.com/spell=450004/magis-spark.

    The talent simply modifies the Touch of the Magi debuff. So the changes here take that into account. Applying the three ability debuffs (magis_spark_arcane_barrage, magis_spark_arcane_missles, and magis_spark_arcane_blast) now apply properly when Touch of the Magi is cast, and Arcane Blast is recommended once even while in AOE range.

  • Destro immolate adjustment

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Arms/Fury priority updates

  • Assassin priority update

  • Shadow priority update

  • Brewmaster CB adjustment

  • Balance priority update

  • Assassin: Fix cold_blood some more

  • Shadow: Make Mind Blast flash consistently?

  • DK priority updates

  • Merge pull request Hekili#3648 from syrifgit/thewarwithin
    Finish Global Funnel damage support

  • Shadow: Control MB/VB texture

  • You don't actually use this sublist.
    as per explanation by spec TC, Porom.

  • Merge branch 'Hekili:thewarwithin' into thewarwithin

  • Actually fix cold blood this time

  • legacy support

  • fix space

  • Guardian Pack String out of date
    But using the right paste this time

  • Guardian Pack String out of date
    didn't include the mitigation list, it now does

  • Devoker update

  • ProtPal update

  • Balance update

  • Voidwraith maybe

  • Feral update and Sabertooth fix

  • Frost DK update

  • Assassination Rogue global funnel support

  • Pack String

  • Assassination Rogue global funnel support

  • enhance global funnel support

  • better description

  • Funnel Toggle Support: Enhance

  • Specify which specs can funnel

  • Improve recheck timer

  • Probably fix Hekili#3641

  • Protection Paladin: Fix holy_armaments

  • Resto Surging Totem

  • Destro interrupt

  • Integrate PR#3629 changes

  • Merge branches 'thewarwithin' and 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Merge pull request Hekili#3640 from ambonif/patch-3
    Update Items.lua - Add some dungeon trinkets

  • Merge branch 'thewarwithin' into patch-3

  • Outlaw poisons

  • Arms, Fury updates

  • DMC: Ascendance

  • Subtlety update

  • Arcane update

  • Feral fixes

  • Havoc update

  • Affliction, Destruction updates

  • Update Items.lua - Add some dungeon trinkets
    Have tested on Signet of the Priory, but not all

  • Paladin: Hammer of Light fixes

  • Windwalker priority update

  • Outlaw: Loaded Dice option fix

  • Frost Mage priority update

  • Arcane priority update

  • Resto Druid: if meow then rawr

  • Balance update from SimC

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Demon Hunter updates

  • Merge pull request Hekili#3620 from davidmann4/guardian_add_mitigation_apl
    added Guardian druid mitigations (soothe, regrowth, renewal, frenzied_regeneration, survival_instincts, barkskin)

  • add mitigation actions as call_action_list

  • WW Tiger Palm

  • Warlock priority updates

  • Merge pull request Hekili#3596 from looterz/tww-pvp-trinkets
    Add The War Within PVP Trinkets

  • Merge pull request Hekili#3603 from ambonif/patch-1
    Vengeance Demon Hunter Fel Scarred Abilities SpellIDs

  • Merge pull request Hekili#3602 from AzuraZJ/thewarwithin
    Fix arcane mage Spellfire Spheres bug

  • Update DemonHunterVengeance.lua
    Add function to change spell IDs for Fel Scarred abilities. Fixes showing of keybinds during recommendation.

  • Update MageArcane.lua
    Add Spellfire Spheres to arcane mage aura list.

  • Protection Paladin divine_armaments

  • WW priority update

  • Arcane updates

  • Add The War Within PVP Trinkets

  • Windwalker priority update

  • Fix Hekili#3584

  • Gravity Lapse

  • Frostfire fixes

  • Fix Hekili#3585

  • Presumably fix Hekili#3589

  • Fix Hekili#3592

  • Blood priority update

  • Frost DK priority update

  • Unholy priority update

  • Fix Hekili#3550 ?

  • Merge pull request Hekili#3578 from syrifgit/thewarwithin
    Shadow, Balance

  • Void Blast (fix Hekili#3565 ?)

  • Fix Hekili#3562

  • Holy Priest update

  • Retribution update

  • Fix Hekili#3559

  • Test (partial) fix for Reaver's Glaive

  • Fix Hekili#3581

  • Chicken form is baseline now

  • Spriest - talent typo

  • Fury/Prot: Try to make thunder_blast SpellFlash

  • Enhancement: Tempest spell ID

  • Shadow: Fix void_blast id

  • Unholy DK: wound_spender includes Vampiric Strike

  • Blood DK auras

  • Reaver's Glaive talent requirement oopsy

  • Frost DK priority update

  • Feral: Split Ravage vs. FB.

  • Testfix for Hekili#3524 (allow rechecking based on death_and_decay.ticking)

  • Testfix for Hekili#3521

  • WW: Allow Hit Combo breakage?

  • Testfix for Hekili#3550

  • (Test) fix Hekili#3553

  • Havoc: Fix Hekili#3515

  • Fix Hekili#3531

  • Possible fix for Hekili#3555

  • Elemental: Fix Hekili#3522

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Unholy: Festering Scythe spell ID fix

  • Affliction: Fix Hekili#3549

  • Merge pull request Hekili#3548 from syrifgit/thewarwithin
    Ret Pal, Sub Rogue, Destro Lock, DPS DKs, Druid

  • Balance Druid - Starlight Conduit typo

  • Frost DK - Antimagic Shell is baseline now

  • Unholy DK - Antimagic Shell is baseline now

  • UI Clarity in Destro Lock settings for Funnel Rotation
    Also, it wasn't actually working (not respecting the toggle), this change also fixes that.

    Additionally made the pet selection dropdown not go all the way across the screen with right-hand justified text which is not intuitive to read

  • UI Clarity in Sub Rogue settings for Funnel Rotation

  • Hammer of light costs 5 holy power

  • Enh/Ele utility stuff

  • WW priority testfix

  • Arms/Fury updates

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Fury priority update and fixes

  • Merge pull request Hekili#3539 from mkaliaha/fix_bladestorm
    Register copy of Bladestorm with Unrelenting Onslaught hero talent

  • Outlaw priority tweak

  • Enhancement priority update

  • Guardian priority update

  • Subtlety mechanics

  • Check subtree is active before adding talent points.

  • Register copy of Bladestorm with Unrelenting Onslaught hero talent

  • Assorted spell overrides

  • Retribution HoL fix

  • Survival priority update

  • Frost DK priority update

  • Feral priority update

  • Havoc priority update; some mechanics

  • pkgmeta

  • Assassination priority update

  • Enhancement variable tweak

  • Shrink profile import box

  • Warlock priority updates (some not mechanically sound)

  • Move some auras; update Ele/Enh

  • Assassin priority adjustment

  • Outlaw/Sub: Minor updates

  • Shadow priority update

  • Prot Pal priority pupdate

  • WW priority update

  • Reorder profile import log

  • Brewmaster PB fix

  • Frost Mage priority update

  • Marksmanship priority update

  • Merge branch 'thewarwithin' of https://github.com/Hekili/hekili into thewarwithin

  • Beast Mastery priority update

  • Venga: Questionable sim update

  • Remove extra line

  • Guardian: Sim priority update

  • Feral: Fix Ferocious Bite

  • Remove casting when casts finish.

  • Merge pull request Hekili#3498 from Wyste/war_within
    Fury WAR: Add Whirlwind mechanics to TC

  • Merge pull request Hekili#3507 from syrifgit/thewarwithin
    Addon UI Updates

  • Add funnel global option
    Framework, currently not linked to any specs

  • Getting Started
    Not in dropdown form yet, but want to get it synced up before continuing to iterate

  • Merge branch 'Hekili:thewarwithin' into thewarwithin

  • WAR: Minor formatting

  • WAR: Add WW mechs to TC when Crashing Thunder talented

  • Possible fix for channeling blocking.

  • Frost DK priority update

  • Marksmanship priority update

  • Fire: priority update

  • Outlaw, Subtlety priority updates

  • Shaman: disambiguate Tempest/LB; update priorities

  • Warrior priority updates

  • Fix Hekili#3488

  • GetSpellInfo bugs

  • Fix Hekili#3489

  • Fix typo

  • Merge pull request Hekili#3464 from yurikenus/master
    Various Changes from HPal Testing

  • Merge pull request Hekili#3453 from Wyste/war_within
    Warrior 11.0.2 changes

  • Specialization updates.

  • Fix MageFrost GetSpellInfo

  • Fix IsSpellActive

  • TWW Warrior Slayer spec changes

  • Survival priority fix

  • Fix line_cd

  • Havoc priority tweaks

  • Blood, Frost DK, Vengeance, Balance, Feral 11.0.2 changes

  • Blood: Coagulating Blood

  • 11.0.2

  • Feral priority update

  • Move debug message

  • Fix Hekili#3471

  • Druids use MOTW

  • Modernize toggle notification

  • Unholy priority update

  • Shadow: update priority to buff PW:F

  • Survival: Remove Coordinated Assault macro option

  • MM: Priority fix for Steady Focus

  • Protection Paladin priority pupdate

  • BM, Survival priority updates, fixes

  • Assassin priority fix

  • Added Consecration Buff for Strength of Conviction
    Consecration: Strength of Conviction talent gives a buff (188370) which you can lose by walking out of it, so buff.consecration.up won't detect it using the other code handling that. I added this buff to detect only the you're-standing-in-it-now part as that might want to trigger an early recast for folks. I confirmed that the spell ID is the same whether you have 1 or 2 points in the talent.

  • Various Changes from HPal Testing

    • Afterimage: added stack tracking and usage for Afterimage, which is under a separate spell ID 400745. Spending holy power adds stacks, casting Word of Glory can remove them. Tested stacking and it caps at 39, and using WoG only removes 20 stacks. The WoG that triggers spending will also add stacks if HP was spent. If HP wasn't spent due to Divine Purpose or Shining Righteousness, stacks are not added.
    • Blessing of Sacrifice: cooldown was increased in 11.0.
    • Rising Sunlight: this can stack to 4, so if you use Divine Toll *and Wings (in either order), you can have 4 stacks up at once.
  • Affliction: Add preferred pet setting

  • Unholy priority update

  • Marksmanship priority update

  • Shadow priority update

  • Assassin, Outlaw updates

  • Ret: Fix Templar Slash texture

  • Survival: Fix Serpent Sting ID, loosen KC requirements

  • MM uses Counter Shot, not Muzzle

  • Frost DK: Razorice target swap (maybe)

  • Destruction: Shadowburn

  • Survival: Fix RS/MB swap ability

  • Fix some ability stub imports.

  • Mistweaver: Remove old Chi Burst aura

  • Monk: Chi Burst, Touch of Karma fixes

  • Feral: Skull Bash, Soothe

  • Warrior 11.0.2 changes

  • Shadow: Fix buff.entropic_rift.enabled -> .up

  • Augmentation: Maybe detect Breath of Eons with Maneuverability

  • Unholy priority update

  • Unholy priority update

  • Devastation: Add missing Azure Strike to st priority

  • Holy Paladin: Set talent requirements on beacon_of_x

  • Clear cast-while-casting whitelist after finishing cast/channel.

  • Survival priority update; fix Viper's Venom

  • Tweak Arcane priority with cancel_pom option

  • Feral priority update

  • More debug in snapshot.

  • Outlaw, Affliction: Priority adjustments

  • Retribution: Remove duplicate Rebuke

  • Affliction: Tweak trinket usage

  • Streamline Death Knight priorities

  • Streamline Demon Hunter priorities; fix priority versioning

  • Streamline Feral, Resto Druid priorities

  • Streamline Devastation priority

  • Streamline Hunter priorities

  • Streamline Mage priorities; sim updates

  • Holy Paladin tweaks

  • Holy, Retribution priority adjustments

  • Streamline Shadow priority

  • Streamline Rogue priorities

  • Streamline Shaman priorities

  • Warrior buffs

  • Affliction: Unstable Affliction fix

  • Flag opener talents for hero trees

  • Iterate on hero_tree.

  • Globals

  • Demo: Adjust APL for TWW cooldown timings

  • Filter targets when GetRange is invalid

  • Update tutorial and warning text/UI

  • Shadow: sim priority update

  • Aff: Fix Shadow Embrace stacks

  • Respect Hunter's Mark setting; Sv: Use Harpoon

  • Fix (some of) trinket proc type expressions

  • Remove Soul Swap code.

  • Shadow: Priority update (SW:D)

  • WW: Allow TP in AOE without Ordered Elements

  • Aff: New spell ID for Shadow Embrace

  • Outlaw: Respect LD Opener setting in priority

  • Remove auto-generated modules

  • Fix global/none -> spell/off GCD

  • Discipline: Fix talents

  • Resto Druid: DPS priority (doesn't heal)

  • Frost DK: Trinket usage

  • Holy Paladin: Fix consecration.X

  • Feral: Prowl before Cat

  • Holy Paladin: Use racials

  • Windwalker: simc update

  • Fix dispellable_x de/buffs

  • Brewmaster: Use Expel Harm

  • Merge pull request Hekili#3430 from ChrisKader/FeralUpdates
    [Feral] Remove Haste from some Feral Spell Durations

  • [Feral] Remove Haste from some Feral Spell Durations

  • Fix SpellFlash again

  • Guardian priority tweaks since sim priority is basic rn

  • Unholy: Add Mind Freeze

  • Fury priority update

  • Frost DK priority update

  • Healers

  • Outlaw: Remove Crackshot Lock