FixCardData.get() to respect default values when None (#2770)

* fix getter in CardData * typo * fix
huggingface · Jan 23, 2025 · b0a42ad · b0a42ad
1 parent 8aa1623
commit b0a42ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/huggingface_hub/repocard_data.py b/src/huggingface_hub/repocard_data.py
@@ -221,7 +221,8 @@ def __str__(self):
 
     def get(self, key: str, default: Any = None) -> Any:
         """Get value for a given metadata key."""
-        return self.__dict__.get(key, default)
+        value = self.__dict__.get(key)
+        return default if value is None else value
 
     def pop(self, key: str, default: Any = None) -> Any:
         """Pop value for a given metadata key."""

diff --git a/tests/test_repocard_data.py b/tests/test_repocard_data.py
@@ -63,6 +63,12 @@ def test_metadata_behave_as_dict(self):
         self.assertTrue("foo" in metadata)
         self.assertFalse("FOO" in metadata)
 
+        # default value
+        # Should return default when key is not in metadata
+        self.assertEqual(metadata.get("FOO", "default"), "default")
+        # Should return default when key is in metadata but value is None
+        metadata.FOO = None
+        self.assertEqual(metadata.get("FOO", "default"), "default")
         # export
         self.assertEqual(str(metadata), "foo: BAR")