-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install issues #191
Merged
aliberts
merged 4 commits into
main
from
user/aliberts/2024_05_17_downgrade_torchvision
May 23, 2024
Merged
Fix install issues #191
aliberts
merged 4 commits into
main
from
user/aliberts/2024_05_17_downgrade_torchvision
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_17_downgrade_torchvision
Cadene
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion!
README.md
Outdated
Comment on lines
80
to
82
> **NOTE:** Depending on your platform, If you encounter any build errors during this step | ||
you may need to install `cmake` and `build-essentials` for building some of our dependencies. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> **NOTE:** Depending on your platform, If you encounter any build errors during this step | |
you may need to install `cmake` and `build-essentials` for building some of our dependencies. | |
> **NOTE:** Depending on your platform, If you encounter any build errors during this step | |
you may need to install `cmake` and `build-essentials` for building some of our dependencies. On linux: |
sudo apt install cmake build-essentials
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
cmake
andbuild-essential
to readme install instructions to help with issues like Installation fails (egl_probe) #105How it was tested
See this thread on discord