Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing target perplexity but #10

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Fixing target perplexity but #10

merged 9 commits into from
Feb 5, 2024

Conversation

thomwolf
Copy link
Member

@thomwolf thomwolf commented Feb 1, 2024

Small but fine

@thomwolf thomwolf requested a review from clefourrier February 1, 2024 14:28
@clefourrier clefourrier changed the base branch from nathan-bump-brrr-model to main February 1, 2024 15:39
@clefourrier clefourrier changed the base branch from main to nathan-bump-brrr-model February 1, 2024 15:39
@clefourrier clefourrier changed the base branch from nathan-bump-brrr-model to main February 1, 2024 15:52
@clefourrier clefourrier force-pushed the fix-target-perplexity branch from 1e7eb76 to 28ec926 Compare February 1, 2024 15:56
clefourrier
clefourrier approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@clefourrier clefourrier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
You might want to add some checks in case we have several gold_idx since it can be a list

@thomwolf thomwolf merged commit 1925742 into main Feb 5, 2024
0 of 2 checks passed
NathanHB added a commit that referenced this pull request Feb 5, 2024
@NathanHB
Revert "Merge pull request #10 from huggingface/fix-target-perplexity"
62530fd 
This reverts commit 1925742, reversing
changes made to 0cf83ce.
NathanHB added a commit that referenced this pull request Feb 5, 2024
@NathanHB
Revert "Revert "Merge pull request #10 from huggingface/fix-target-pe…
7fc1fe9 
…rplexity""

This reverts commit 62530fd.
NathanHB added a commit that referenced this pull request Feb 5, 2024
@NathanHB
Revert "Merge pull request #10 from huggingface/fix-target-perplexity"
6c88539 
This reverts commit 1925742, reversing
changes made to 0cf83ce.
NathanHB added a commit that referenced this pull request Feb 5, 2024
@NathanHB
Revert "Merge pull request #10 from huggingface/fix-target-perplexity"
ba3e2ee 
This reverts commit 1925742, reversing
changes made to 0cf83ce.
clefourrier pushed a commit that referenced this pull request Feb 6, 2024
@NathanHB
Revert "Merge pull request #10 from huggingface/fix-target-perplexity" (
c50e19f 
#14)

* Revert "Merge pull request #10 from huggingface/fix-target-perplexity"

This reverts commit 1925742, reversing
changes made to 0cf83ce.

* fix
@clefourrier clefourrier mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomwolf @clefourrier @NathanHB