Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug of import url_to_fs from fsspec (#507) #512

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fixed bug of import url_to_fs from fsspec (#507) #512

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3d8f47
Fixed bug of import url_to_fs from fsspec (#507)
LoserCheems Jan 24, 2025
c6a226e
Add a try catch as import depend on fsspec version
clefourrier Jan 24, 2025
d2b1bc8
Fixed code quality
LoserCheems Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lighteval/logging/evaluation_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import torch
from datasets import Dataset, load_dataset
from datasets.utils.metadata import MetadataConfigs
from fsspec import url_to_fs
from huggingface_hub import DatasetCard, DatasetCardData, HfApi, HFSummaryWriter, hf_hub_url

from lighteval.logging.info_loggers import (
Expand All @@ -53,6 +52,11 @@
if is_nanotron_available():
from nanotron.config import GeneralArgs # type: ignore

try:
from fsspec import url_to_fs
except ImportError:
from fsspec.core import url_to_fs


class EnhancedJSONEncoder(json.JSONEncoder):
"""
Expand Down
Loading