Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for flash decoding on xpu #1118

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

add support for flash decoding on xpu #1118

wants to merge 9 commits into from

Conversation

kaixuanliu
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@kaixuanliu
Copy link
Contributor Author

kaixuanliu commented Feb 6, 2025 •
edited
Loading

@echarlaix @IlyasMoutawwakil Hi, pls help review.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kaixuanliu
fix format issue
23a3b54 
Signed-off-by: Liu, Kaixuan <[email protected]>
@kaixuanliu
Copy link
Contributor Author

@echarlaix @IlyasMoutawwakil Hi, Can you help review and merge?

IlyasMoutawwakil
IlyasMoutawwakil requested changes Feb 15, 2025
View reviewed changes
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but let's prioritize using private attributes/variables.

@kaixuanliu
refine code
3616dd2 
Signed-off-by: Liu, Kaixuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyasMoutawwakil IlyasMoutawwakil IlyasMoutawwakil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaixuanliu @HuggingFaceDocBuilderDev @IlyasMoutawwakil