Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align rt_info int8 models compressed by default and via config #1130

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Jan 28, 2025

What does this PR do?

currently --weight-format int8 and models compressed to int8 by default based on number of parameters has slightly different behaviour in respect of kv cache compression.

see example (left default, right with --weight-format int8):

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova requested a review from AlexKoff88 January 28, 2025 13:53
@eaidova eaidova force-pushed the ea/enable_kv_cache_compression_if_default_compressed branch from 28dfaf6 to ce34562 Compare January 28, 2025 13:55
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88
Copy link
Collaborator

Merging as a hotfix

@AlexKoff88 AlexKoff88 merged commit a59bb41 into huggingface:main Jan 29, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants