Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sanity test for docker build and run #831

Merged
merged 24 commits into from
Jul 29, 2024

Conversation

rbrugaro
Copy link
Contributor

Add sanity test for docker build and run
@IlyasMoutawwakil this is in response to your request in closed PR #821

@IlyasMoutawwakil
Copy link
Member

I think It's better to automate the sanity test by doing this in a GitHub workflow, that's triggered when the dockerfile changes.

@rbrugaro rbrugaro marked this pull request as draft July 23, 2024 16:32
@rbrugaro rbrugaro marked this pull request as ready for review July 23, 2024 17:46
@rbrugaro
Copy link
Contributor Author

Thx @IlyasMoutawwakil, understood! I moved the build and run check to github workflow

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

branches:
- main
paths:
- 'Dockerfile.intel'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/Dockerfile.intel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! I used workflow_dispatch to manually trigger and test the workflow and forgot to update path for the auto triggering with file changes. Added!

@IlyasMoutawwakil IlyasMoutawwakil merged commit 7a224c2 into huggingface:main Jul 29, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants