Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotswap allow different alpha scalings and ranks #2177

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
355e2ab
[WIP] Allow different alphas for hotswapping
BenjaminBossan Oct 24, 2024
135dfda
Only enable hotswap tests in CI for now
BenjaminBossan Oct 24, 2024
9b7d979
More debugging
BenjaminBossan Oct 24, 2024
3a6d4b5
Merge branch 'main' into hotswap-allow-different-alpha-scalings
BenjaminBossan Oct 24, 2024
088a9d9
More debugging
BenjaminBossan Oct 24, 2024
3da33ba
Take alpha from new config
BenjaminBossan Oct 24, 2024
0bba669
Remove some debug code
BenjaminBossan Oct 24, 2024
c73dafc
Merge branch 'main' into hotswap-allow-different-alpha-scalings
BenjaminBossan Nov 28, 2024
552ecac
Compiled hotswapping works w/ different scalings
BenjaminBossan Nov 28, 2024
2dcd6a1
[WIP] Hotswap with different ranks
BenjaminBossan Nov 28, 2024
620d43e
Make hotswapping with different ranks work
BenjaminBossan Nov 29, 2024
efaf2b0
More tests, docs, fixes
BenjaminBossan Dec 2, 2024
25d7a77
Make style, fix
BenjaminBossan Dec 2, 2024
88bd814
Merge branch 'main' into hotswap-allow-different-alpha-scalings
BenjaminBossan Jan 8, 2025
2a29370
Remove obsolete test
BenjaminBossan Jan 8, 2025
9b132ec
Merge branch 'main' into hotswap-allow-different-alpha-scalings
BenjaminBossan Jan 24, 2025
ddf1bad
Disable test skips for CI (only testing)
BenjaminBossan Jan 24, 2025
3251c6c
Clean up, documentation
BenjaminBossan Jan 28, 2025
9966c10
Reviewer feedback: Refactor _pad_lora_weights
BenjaminBossan Jan 30, 2025
01924ad
Reviewer feedback: Add clarifying comments
BenjaminBossan Jan 30, 2025
66b987e
Fix issue with bias term
BenjaminBossan Jan 31, 2025
d32d23f
Clarify docstring
BenjaminBossan Jan 31, 2025
8b7e602
Reviewer feedback:
BenjaminBossan Feb 3, 2025
d0a1fc5
Reviewer feedback: add clarifying comments
BenjaminBossan Feb 4, 2025
7772e2e
Reviewer feedback: address model.compile()
BenjaminBossan Feb 4, 2025
fe19da5
Revert testing
BenjaminBossan Feb 4, 2025
5bc0dbe
Simplify tests for recompilation
BenjaminBossan Feb 5, 2025
a412f7a
Reviewer feedback: Better handling of torch cache
BenjaminBossan Feb 5, 2025
0943519
Change fixture to clean up dynamo cache after test
BenjaminBossan Feb 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 0 additions & 146 deletions tests/run_compiled_diffusion_model_hotswap.py

This file was deleted.

92 changes: 0 additions & 92 deletions tests/run_compiled_model_hotswap.py

This file was deleted.

Loading
Loading