Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip dangerous modules instead of dangerous patterns #877

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip dangerous modules instead of dangerous patterns #877

wants to merge 3 commits into from

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Mar 4, 2025 •
edited
Loading

Skip dangerous modules instead of dangerous patterns.

After this PR:

  • we support the inoffensive import of pandas.io
  • we no longer (info) log the skipping of dangerous attributes

Fix #663.
Supersede and close #664.

aymeric-roucher
aymeric-roucher approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@aymeric-roucher aymeric-roucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the error could be made more explicit? For me "Forbidden return value: os") does not hint at why the import was refused. Maybe Forbidden import: osor somthing in that vein would be clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-roucher aymeric-roucher aymeric-roucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Skipping dangerous attribute" check
2 participants
@albertvillanova @aymeric-roucher