feat: add /similarity route
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OlivierDehaene Would it make sense to make it compatible with huggingface-hub client: https://github.com/huggingface/huggingface_hub/blob/ca111fb51193968faed548a4b865c79736822aed/src/huggingface_hub/inference/_client.py#L1416 ? It looks like they expect a bit different names for the attributes of |
|
What do you mean? It is compatible. |
|
The payload is: https://github.com/huggingface/huggingface_hub/blob/ca111fb51193968faed548a4b865c79736822aed/src/huggingface_hub/inference/_client.py#L1457 which is what we expect here. |
|
Oh, my apologies, I must've looked at a different revision or something (probably got confused with the python method args). Thanks for the quick reply! |
pi314ever
pushed a commit
to pi314ever/tei-gaudi
that referenced
this pull request
Aug 21, 2024
pi314ever
pushed a commit
to pi314ever/tei-gaudi
that referenced
this pull request
Aug 26, 2024
MasakiMu319
pushed a commit
to MasakiMu319/text-embeddings-inference
that referenced
this pull request
Nov 27, 2024
aagnone3
pushed a commit
to StratisLLC/hf-text-embeddings-inference
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for compatibility.