Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom subsections in education #888

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

BernatBC
Copy link
Member

Issue

Fixes #400

Description

Added custom subsections in education cards. The configuration is the following:

degrees:
- name: Degree name
    # Other configs
    custonSections:
    - name: Subsection Title
      content: Content
    - name: Subsection Title 2
      content: Content 2

Test Evidence

image

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit fcf777d
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/65ca4e6a93720a0008df71a5
😎 Deploy Preview https://deploy-preview-888--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BernatBC for the PR. Added a comment. Please, take a look.

layouts/partials/sections/education-alt.html Outdated Show resolved Hide resolved
@BernatBC
Copy link
Member Author

Ok @hossainemruz ,
I've applied that change. What's your view on this change?

@hossainemruz
Copy link
Member

The change looks good. Any screenshot?

@BernatBC
Copy link
Member Author

image

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BernatBC. Looks good now.

@hossainemruz hossainemruz merged commit cbdb07d into hugo-toha:main Feb 12, 2024
10 of 12 checks passed
@BernatBC BernatBC deleted the education-custom-subsections branch February 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature in education: supervisors & thesis
2 participants