Fix index out of range error when data not found

[Yao-Wen-Chang]

close #437

[hugovk]

Running against a project which doesn't exist on PyPI and getting results in JSON format:

❯ pypistats python_major testbrojct -f json
{"data": [], "package": "testbrojct", "type": "python_major_downloads"}

However, we still get the error when asking for results in other formats:

❯ pypistats python_major testbrojct
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/bin/pypistats", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/cli.py", line 372, in main
    args.func(args)
  File "/Users/hugo/github/pypistats/src/pypistats/cli.py", line 258, in python_major
    pypistats.python_major(
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 497, in python_major
    return pypi_stats_api(endpoint, params, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 169, in pypi_stats_api
    data = _percent(data)
           ^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 322, in _percent
    grand_total = _grand_total_value(data)
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 282, in _grand_total_value
    if data[0]["category"] in ["with_mirrors", "without_mirrors"]:
       ~~~~^^^
IndexError: list index out of range

❯ pypistats python_major testbrojct -f html
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/bin/pypistats", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/cli.py", line 372, in main
    args.func(args)
  File "/Users/hugo/github/pypistats/src/pypistats/cli.py", line 258, in python_major
    pypistats.python_major(
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 497, in python_major
    return pypi_stats_api(endpoint, params, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 169, in pypi_stats_api
    data = _percent(data)
           ^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 322, in _percent
    grand_total = _grand_total_value(data)
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hugo/github/pypistats/src/pypistats/__init__.py", line 282, in _grand_total_value
    if data[0]["category"] in ["with_mirrors", "without_mirrors"]:
       ~~~~^^^
IndexError: list index out of range

Let's also handle these too. And please can you add some tests?

For example, see a43357d that added the KeyError handling with tests.

[Yao-Wen-Chang]

I will fix those bugs and add the test.

[Yao-Wen-Chang]

Instead of handling with those errors, I prefer to check if res["data"] is an empty list at this line here.
If it's empty, the function returns the message: 'The package 'sssssssssssssssssssssssssss' does not exist.'

I will add the test to check the return message.

[Yao-Wen-Chang]

Do you know why using the
Command: pypistats python_major -j aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
it returns 200, but
Command: pypistats overall -j aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
it returns 404 from the API call, then raises the exception.

Reasonably, both should return 404, because the package does not exist.

[hugovk]

I don't know.

If we run with --verbose it shows the API endpoints:

• https://pypistats.org/api/packages/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/python_major

• https://pypistats.org/api/packages/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/overall

As you say, the first returns 200 with empty data, the second is 404.

Turns out I already reported this upstream 3 years ago, but there's been no response so we'll have to live with it:

• API: 404 is returned for some endpoints but not others crflynn/pypistats.org#43

[Yao-Wen-Chang]

For this line in the code:

pypistats/src/pypistats/__init__.py

Line 121 in bfda2c9

r.raise_for_status()

Do you think it would be a good idea to delete it, considering it raises an error message?

[hugovk]

Thank you!