202312 action checking pr age #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-framework#3861) * [all] Change variable name supportOnlySymmetricMatrix in MechanicalParams * propagate the supportOnlySymmetricMatrix API change * Add deprecation --------- Co-authored-by: Alex Bilger <[email protected]>
…a-framework#3858) * [Constraint.Lagrangian] Add messages when no compliance is given * minor esthetic msg update
… branch (sofa-framework#3515) * WIP * CRS: integration from issofa * rename all bloc to blocks * use MessagingAPI (and rename again bloc to block * add matrix_bloc_traits for Vec * fix compilation with CRS debug macros * revert some useless changes * add insimo as contributors * fix compilation test by bringing back operators and MatrixExpr * fix stuff about add() * add compress() after clearing (fix some tests?) * fix debug compilation * clarify add() functions (indices, etc) * apply insimo code and clean ups * rename CRS for CRSGeneric * apply insimo code for CRSMechanical (previous CRS) and clean ups * add transitional header * fix confusion about mul() * bring back some changes from original version * bring back BM:add with mat3 and various fixes * fix gcc * remove conversion warnings * fix tests and stuff * Use struct instead of class (+public) Co-authored-by: Alex Bilger <[email protected]> * remove diag/debug/trace api in crs * remove now-useless CRS trace logger utility header * remove some override warnings * remove more warnings * fix rebase * refresh scene with MechanicalMatrixMapper * change traits to try to match previous behavior * fix missing include * add explicit instanction for float type * apply suggestion by using directly the correct type * remove the touch trait --------- Co-authored-by: Alex Bilger <[email protected]>
It is not used, and its content is deprecated in Cuda 12
…work#3870) [Config] Fix cross-compilation by turning off cmake_find_root_path for embedded external libs
* [all] Deprecate unused verbose data * Add warning in parse method
sofa-framework#3887) [SolidMechanics] Use accessors & make geometrical data required in BeamFEMFF
…ofa-framework#3868) * [SofaCUDA] Remove non-working scene * Introduce example * nodesPerElement * DhC0, DhC1 and DhC2 * detJ * Disp * hourglass control * preferredDirection * Di1, Di2, Dv1, Dv2 * force coordinates * Fi * x, x0 * Ignore added scene on CI
…ework#3913) [Helper] Improve test for users in component change
…ld (sofa-framework#3821) * add functions to visualization of tetrahedron fem force field * fix naming and minor problem * add scale function * avoid using data access in a loop: d_showElementGapScale * add callbacks on data and remove warning * make member variable name clearer and prefix, use Real instead of float --------- Co-authored-by: Hugo Talbot <[email protected]>
* fix warning about deprecate verbose * rename to blocks and other trivial warnings * fix other warnings in plugins
* [ForceField] Add direction option in RestShapeSpringsFF The idea of this commit is to add the ability for a user to select in which directions the RestShapeSpringsFF will be effective during simulation. For this we add a new data field containing 6 booleans: one for each direction of effort (3 directions of translation, 3 of rotation). For each entry, "true" indicates that the direction will be taken into account, and "false" that it won't. The default value of the parameter is set to [1 1 1 1 1 1], so that all directions are taken into account if the parameter is not specifically provided by the user. This way, we expect the component not to be breaking. /!\ At the moment, we only implemented the restriction for translations, but not for rotations. Concretely, changing one of the last 3 entries of the data field to "false" doesn't have any effect on the simulation. The implementation for rotations should be the object of further commits. * [ForceField] Add test scene to test the new RestShapeSpringsFF option * [ForceField] Extend direction option in RestShapeSpringsFF Following previous commit, we extend the direction option to rotations. * [ForceField] Update RestShapeSpringsFF test scene * [ForceField] Fix warning in test scene * [ForceField] Add callback in RestShapeSpringForceField The callback is meant to recompute the internal variables of the components if the input MechanicalObject indices are changed dynamically. * Make activeDirections more generic * No need to be a Vec * make description matches dimension * Fix wrong size * Set component state * Fix scene * Remove check of component state This is going to be checked earlier (but in another pull request) * Refactor setting the component state It now follow the same pattern used in other components: the component state is set to valid only at the end --------- Co-authored-by: Camille Krewcun <[email protected]>
* [all] Minor clean of types * ValuesFromIndices from double to SReal
…ework#3918) * [Core] Access cumulative sum of VecIds through proxy class This is to take into account the geometric stiffness in non-linear mappings. It has to take into account the sum of all forces applied on a MechanicalObject. Therefore, a list of VecIds is maintained and accessed later. * Return a const ref * Cache element access due to the calls of getValue
…amework#3914) * [Logging] Suggestion to better highlight warnings in console * new color suggestion
…nceFromTargetMapping + example (sofa-framework#3921)
[Plugins] ADD Hadrien's collisionAlgorithm and ContraintGeometry to oerternal plugins Co-authored-by: Paul Baksic <[email protected]>
…work#3891) * Rename file DefaultContactManager into CollisionResponse * Update Compat layer with the new class name * udpate CMakeLists with new class name * udpate CMakeLists with new class name keeping compat file * update class name in the code * propagate the change of C++ class name * add compatibility file * update all scenes with new component name CollisionResponse * Apply suggestions from code review Co-authored-by: Alex Bilger <[email protected]> * [LinearAlgebra] Change access specifier for the method set (sofa-framework#3834) * Change access specifier for the method set. Needed in SofaCUDASolver plugin. Regardless the resons of this modification, The fact that this method is at the begining of the class declaration without any access specifier befoe is not usual * Changed attributs/methods orders and remove repeated identifiers --------- Co-authored-by: Paul Baksic <[email protected]> * [Spring] Remove unused dependencies (sofa-framework#3848) * [StateContainer] Fix bug in dynamic data registration (sofa-framework#3783) * [Sofa.Type] Replace the use of Matrix::s_identity (deprecated) by Matrix::Identity() * [Sofa.Component.StateContainer] Fix missing registration of dynamic properties. Signed-off-by: Damien Marchal <[email protected]> --------- Signed-off-by: Damien Marchal <[email protected]> * [SceneChecking] Add check when setting contactStiffness uselessly (sofa-framework#3843) * [SceneChecking] Add check when setting contactStiffness uselessly * Separate contribution in a separate function * [test] Fix unit test on RestShapeSpringsForceField (sofa-framework#3864) * [plugins] Remove fetching of SofaPython (sofa-framework#3855) * [Constraint.Lagrangian] Activate the export of lambda forces by default (sofa-framework#3857) * [all] Change variable name supportOnlySymmetricMatrix in MParams (sofa-framework#3861) * [all] Change variable name supportOnlySymmetricMatrix in MechanicalParams * propagate the supportOnlySymmetricMatrix API change * Add deprecation --------- Co-authored-by: Alex Bilger <[email protected]> * [Constraint.Lagrangian] Add messages when no compliance is given (sofa-framework#3858) * [Constraint.Lagrangian] Add messages when no compliance is given * minor esthetic msg update * [all] include base class inl file (sofa-framework#3865) * [test] Fix failing unit test (sofa-framework#3876) Introduced in sofa-framework#3858 * [LinearAlgebra] Pull Insimo's CompressedRowSparseMatrix into the main branch (sofa-framework#3515) * WIP * CRS: integration from issofa * rename all bloc to blocks * use MessagingAPI (and rename again bloc to block * add matrix_bloc_traits for Vec * fix compilation with CRS debug macros * revert some useless changes * add insimo as contributors * fix compilation test by bringing back operators and MatrixExpr * fix stuff about add() * add compress() after clearing (fix some tests?) * fix debug compilation * clarify add() functions (indices, etc) * apply insimo code and clean ups * rename CRS for CRSGeneric * apply insimo code for CRSMechanical (previous CRS) and clean ups * add transitional header * fix confusion about mul() * bring back some changes from original version * bring back BM:add with mat3 and various fixes * fix gcc * remove conversion warnings * fix tests and stuff * Use struct instead of class (+public) Co-authored-by: Alex Bilger <[email protected]> * remove diag/debug/trace api in crs * remove now-useless CRS trace logger utility header * remove some override warnings * remove more warnings * fix rebase * refresh scene with MechanicalMatrixMapper * change traits to try to match previous behavior * fix missing include * add explicit instanction for float type * apply suggestion by using directly the correct type * remove the touch trait --------- Co-authored-by: Alex Bilger <[email protected]> * [SofaCUDA] Deprecated CudaTexture.h (sofa-framework#3869) It is not used, and its content is deprecated in Cuda 12 * [examples] Fix unstable scene constantMomentum.scn (sofa-framework#3886) * [SofaCUDA] Replace deprecated vector types (sofa-framework#3902) * [Config] Fix cross-compilation for embedded external libs (sofa-framework#3870) [Config] Fix cross-compilation by turning off cmake_find_root_path for embedded external libs * [all] Deprecate unused verbose data (sofa-framework#3871) * [all] Deprecate unused verbose data * Add warning in parse method * [contact] Add missing call to super init (sofa-framework#3884) * [SolidMechanics] Use accessors & make geometrical data required in BFF (sofa-framework#3887) [SolidMechanics] Use accessors & make geometrical data required in BeamFEMFF * [SofaCUDA] No longer use deprecated texture references in HexaTLED (sofa-framework#3868) * [SofaCUDA] Remove non-working scene * Introduce example * nodesPerElement * DhC0, DhC1 and DhC2 * detJ * Disp * hourglass control * preferredDirection * Di1, Di2, Dv1, Dv2 * force coordinates * Fi * x, x0 * Ignore added scene on CI --------- Signed-off-by: Damien Marchal <[email protected]> Co-authored-by: Alex Bilger <[email protected]> Co-authored-by: Paul Baksic <[email protected]> Co-authored-by: Paul Baksic <[email protected]> Co-authored-by: Damien Marchal <[email protected]> Co-authored-by: Alex Bilger <[email protected]> Co-authored-by: Frederick Roy <[email protected]> Co-authored-by: Olivier Roussel <[email protected]>
* WIP * fix vecnoinit/vec, and constexpr init of array * add an other conversion for rgbacolor * correct aliases * fix tests compil * use correct type for getClosest * add compat for picking * polish * change type in image * remove superfluous typenames * no need to clear as it is already zero-init
…onDiagonalMassesCountVisitor and MechanicalVDotVisitor (sofa-framework#4328) * remove ill-used nodedata for nondiagmass visitor * remove ill-used nodedata for vdot visitor * set to const ptr * replace result type by an integer * add keyword for lifecycle
* [github] fix stale action * Remove breaks to apply on ALL topics * add missing filter to avoid writing in answered or closed topics
…4352) * [LinearAlgebra] constexpr if statement when possible * Use structured binding
FIX qt target handling subdirectory was overriding the variable used to store qt target dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if