Add cmake support to LodePNG #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslo
requested changes
Nov 28, 2018
| @@ -0,0 +1,69 @@ | |||
| cmake_minimum_required(VERSION 3.0) | |||
|
|
|||
| # Project is not versioned, so use date of last upstream commit. | |||
There was a problem hiding this comment.
Usually I do 0.0.0 in this case because if they will release for example 1.0.0 then we will have situation when 2018.10.29 is greater than 1.0.0 (see https://semver.org/).
Also VERSION is not a requirement neither for CMake install config nor Hunter, so you are free to remove related parts.
There was a problem hiding this comment.
Got it, thanks. I'll do 0.0.0 then
CMakeLists.txt
Outdated
| set(PROJECT_CONFIG "${GENERATED_DIR}/${PROJECT_NAME}Config.cmake") | ||
|
|
||
| set(CONFIG_INSTALL_DIR "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}") | ||
| set(INCLUDE_INSTALL_DIR "include") |
There was a problem hiding this comment.
Similar variable defined by GNUInstallDirs:
You can use CMAKE_INSTALL_INCLUDEDIR here, example:
ruslo
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to build this library with cmake. Normally, we would contribute this upstream, but there are 3 PRs up to do that, and have not been answered:
It's unclear if the author is receptive to adding CMake support or not.
This change will then allow the package to be used with Hunter.
Tested by pulling in and building/linking against lodepng in both debug and release projects.
After merge, can we make a release version, and then I will pull it in to hunter/hunter?