improve import Bar
#167
Open
improve import Bar
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ConnorLi96 can you help @MindyZHAOMinzhu to address the comments and resolve this PR tomorrow f2f? |
hupili
reviewed
Sep 7, 2019
| @@ -314,7 +314,7 @@ Pyecharts is a library to generate charts using Echarts, which is an open source | |||
|
|
|||
| #### Quickstart for pyecharts | |||
|
|
|||
| Basic usage example: (`pip install pyecharts` if you have not done so yet) | |||
| Basic usage example: (1. use `print(sys.path)`to find your packages location. 2.cd in the path, then `pip install pyecharts==v1.0.0` if you have not done so yet) | |||
There was a problem hiding this comment.
@MindyZHAOMinzhu if steps 1 and 2 are not mandatory, we can remove them from the main body of this book and keep the discussion there concise. The book aims at providing quickest and most direct solution for one to achieve the tasks. If they are interested to know more, they can read issues and further reading materials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.