add comments in redis.conf

hwware · Jan 24, 2023 · 8f83a6e · 8f83a6e
1 parent 1139ea3
commit 8f83a6e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/redis.conf b/redis.conf
@@ -1209,7 +1209,12 @@ acllog-max-len 128
 # in the system. It's a tradeoff between memory, CPU and latency.
 #
 # active-expire-effort 1
-#
+# 
+# It allows the redis to evict keys earlier. The value of this parameter represents
+# percent of the maxmemory value. It means how much memory the redis instance want to hold
+# not to store the data.
+# Default is 0, and the value could be set between 10 to 60.
+# 
 # maxmemory-reserved-scale 0
 
 

diff --git a/src/config.c b/src/config.c
@@ -2463,7 +2463,7 @@ static int updateReplBacklogSize(const char **err) {
     return 1;
 }
 
-static int updateMaxmemoryReserved(const char **err){
+static int updateMaxmemoryReserved(const char **err) {
     UNUSED(err);
     if (server.maxmemory_reserved_scale) {
         if (server.maxmemory_reserved_scale < 10) {

diff --git a/src/evict.c b/src/evict.c
@@ -564,10 +564,6 @@ int performEvictions(void) {
     int slaves = listLength(server.slaves);
     int result = EVICT_FAIL;
 
-    //serverLog(LL_WARNING,"-------------------------------------------------");
-    //serverLog(LL_WARNING,"Current maxmemory reserved scale is: %d",server.maxmemory_reserved_scale);
-    //serverLog(LL_WARNING,"Current maxmemory reserved size is: %lld",server.maxmemory_reserved);
-    //serverLog(LL_WARNING,"Current maxmemory is: %lld",server.maxmemory);
     if (getMaxmemoryState(&mem_reported,NULL,&mem_tofree,NULL) == C_OK) {
         result = EVICT_OK;
         goto update_metrics;