More chromosome testing #123
Conversation
|
Warning Rate Limit Exceeded@hyanwong has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 56 minutes and 3 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update introduces modifications and enhancements to the Genetic Inheritance Graph Library, focusing on improving functionality and testing. Key changes include returning a new object in the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
tests/test_graph.py
Outdated
| def test_samples(self, trivial_gig): | ||
| assert np.all(trivial_gig.sample_ids > 0) # samples are at the end | ||
| n = 0 | ||
| for u, sample in zip(trivial_gig.sample_ids, trivial_gig.samples()): | ||
| assert u == sample.id | ||
| assert sample.time == trivial_gig.nodes.time[u] | ||
| assert trivial_gig.nodes[u].is_sample() | ||
| n += 1 | ||
| assert n == np.sum(trivial_gig.tables.nodes.flags & gigl.NODE_IS_SAMPLE > 0) | ||
|
|
There was a problem hiding this comment.
Potential issue with bitwise operation in assertion.
- assert n == np.sum(trivial_gig.tables.nodes.flags & gigl.NODE_IS_SAMPLE > 0)
+ assert n == np.sum((trivial_gig.tables.nodes.flags & gigl.NODE_IS_SAMPLE) > 0)The original line might not perform the intended check correctly due to the precedence of operators. The suggested change ensures that the bitwise AND operation is evaluated before the comparison, which is likely the intended behavior.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def test_samples(self, trivial_gig): | |
| assert np.all(trivial_gig.sample_ids > 0) # samples are at the end | |
| n = 0 | |
| for u, sample in zip(trivial_gig.sample_ids, trivial_gig.samples()): | |
| assert u == sample.id | |
| assert sample.time == trivial_gig.nodes.time[u] | |
| assert trivial_gig.nodes[u].is_sample() | |
| n += 1 | |
| assert n == np.sum(trivial_gig.tables.nodes.flags & gigl.NODE_IS_SAMPLE > 0) | |
| def test_samples(self, trivial_gig): | |
| assert np.all(trivial_gig.sample_ids > 0) # samples are at the end | |
| n = 0 | |
| for u, sample in zip(trivial_gig.sample_ids, trivial_gig.samples()): | |
| assert u == sample.id | |
| assert sample.time == trivial_gig.nodes.time[u] | |
| assert trivial_gig.nodes[u].is_sample() | |
| n += 1 | |
| assert n == np.sum((trivial_gig.tables.nodes.flags & gigl.NODE_IS_SAMPLE) > 0) |
Summary by CodeRabbit
New Features
Improvements
Tests