[columnar] HYD-760 Serialization fails to copy data #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkaruza
commented
Jan 10, 2024
mkaruza
commented
- When we are building chunk for serialization if serialzation memory is higher than 256MB, memcpy_s function (safeclib) will not copy anything (there is memory size check). Fixed by using memcpy. We have allocated already memory with required size so it should be safe to copy it.
* When we are building chunk for serialization if serialzation memory is higher than 256MB, memcpy_s function (safeclib) will not copy anything (there is memory size check). Fixed by using memcpy. We have allocated already memory with required size so it should be safe to copy it.
|
this is included in #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.