Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to elements 2.2.0-alpha.21 and function 1.11.0-alpha.18 #160

Merged

Conversation

jamesbradleym
Copy link
Contributor

@jamesbradleym jamesbradleym commented Jan 5, 2024

Building Blocks contains many functions that are used in Hypar examples and in the Hypar tour. Please ensure that that following are true before granting this PR.

  • The function has been published with staging, (but not released, until this PR is approved).
  • The function has been tested against the tour. If the function is not used in the tour, mark this as not applicable (NA).
  • Strings in hypar.json have been translated to supported languages in the messages field.
  • Any new project added to this repository has been added to BuildingBlocks.sln.

This change is Reviewable

@jamesbradleym jamesbradleym requested a review from a team as a code owner January 5, 2024 17:12
@jamesbradleym jamesbradleym removed the request for review from anthonie-kramer January 5, 2024 17:36
@jamesbradleym jamesbradleym marked this pull request as draft January 5, 2024 17:36
@jamesbradleym jamesbradleym marked this pull request as ready for review January 5, 2024 18:16
Copy link
Contributor

@anthonie-kramer anthonie-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general warning that when we update to the newer Hypar.Function versions, the 'ElementInstances` won't show in Explore... So just double-check that all objects are showing up as expected.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jamesbradleym)

@jamesbradleym jamesbradleym merged commit 520c766 into master Jan 9, 2024
2 checks passed
@jamesbradleym jamesbradleym deleted the update-grid-to-latest-elements-and-function-versions branch January 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants