Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make-deserialization-thread-safe #1074

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Make-deserialization-thread-safe #1074

merged 2 commits into from
Dec 13, 2023

Conversation

anthonie-kramer
Copy link
Contributor

@anthonie-kramer anthonie-kramer commented Dec 13, 2023 •
edited by andrewheumann
Loading

BACKGROUND:

  • Had an issue with deserialization warnings where they were being accessed in different threads

DESCRIPTION:

  • Adds the ThreadStatic to ensure that this will not be accessed from other threads

TESTING:

  • Deserialization should work running in a published function (I tested with Doors function)

FUTURE WORK:

  • Make sure we are being thread safe!

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

wynged
wynged approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@anthonie-kramer anthonie-kramer merged commit 3ac8386 into master Dec 13, 2023
1 check passed
@anthonie-kramer anthonie-kramer deleted the make-deserialization-thread-safe branch December 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonie-kramer @wynged