Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing column edges by correcting MergeSubResult handling for SharedObjects #1092

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix: missing column edges by correcting MergeSubResult handling for SharedObjects #1092

merged 2 commits into from
Feb 5, 2025

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Feb 5, 2025 •
edited by andrewheumann
Loading

BACKGROUND:

DESCRIPTION:
This PR:

  • Fixes the MergeSubResult method in GatherSubElementsResult, ensuring that elements collected from types related to shared objects are correctly added to ElementsFromSharedObjectProperties.

TESTING:

  • Republishing the Column function (latest TEST version) successfully restored column edges:

image

This change is Reviewable

andrewheumann
andrewheumann approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@katehryhorenko katehryhorenko merged commit e26e2c3 into master Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheumann andrewheumann andrewheumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katehryhorenko @andrewheumann