-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Everything ifc #531
Open
ikeough
wants to merge
41
commits into
master
Choose a base branch
from
everything-ifc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Everything ifc #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One small piece I still need to do. I added a method |
After conversation with @andrewheumann, the following changes are proposed.
Future Work:
|
…into everything-ifc
This is waiting on work to support |
What is missing in this project? |
srudenkoamc
added a commit
to srudenkoamc/Elements
that referenced
this pull request
Sep 7, 2023
The logic for the new class and the changes in IFCExtensions are taken from hypar-io#531 PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
Previously we could only import elements like Walls, Columns, and Beams from IFC. This is because we mapped IFC entities to our corresponding core types. As a short term fix (knowing we're also going to move core types out of elements), we can drop the exact mapping and import everything as a geometric element. This will (I think) enable us to use imported IFC geometry as snap targets.
DESCRIPTION:
GeometricElement
.Openings
toGeometricElement
to align withIfcBuildingElement
.Openings
to theGeometricElement
theIHasOpenings
interface is no longer required and it is removed.REQUIRED:
CHANGELOG.md
.COMMENTS:
This change is