Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds max_pending_accept_reset_streams for legacy #102

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

allan2
Copy link
Contributor

@allan2 allan2 commented Feb 29, 2024

Adds this missing function to the legacy client.

#90 was merged with half of #78. This PR is the other half.

Adds this missing function to the legacy client.
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compile failed. Shall we rebase on the latest master to get the field added?

@tisonkun
Copy link
Contributor

Seems the code itself is wrong. I made a patch at #119.

@allan2 Feel free to merge my commit into this patch. Or @seanmonstar can review #119 instead as I'll actively respond.

Credits are retained. My main target is moving this forward and then hyperium/tonic#1670.

@allan2
Copy link
Contributor Author

allan2 commented Apr 24, 2024

@tisonkun thank you for the fix. Your #119 patch has been merged into this PR.

@seanmonstar seanmonstar merged commit 5688b27 into hyperium:master Apr 25, 2024
32 checks passed
@czy-29
Copy link

czy-29 commented May 7, 2024

Here you need to update the hyper dependency in Cargo.toml to 1.3.x, because hyper::client::conn::http2::Builder in 1.2.x does not have the max_pending_accept_reset_streams method. The hyper of Cargo.toml of the current master branch is still 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants