HTTP/2 server example #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for improving the documentation! I was thinking, since it's so similar to the "hello world" guide, that perhaps what might be best is to just update that guide. Where it links out to the example, add a few words "(and a similar example using HTTP/2)". What do you think? |
|
Ya I think that is good. I will work on that. |
|
@seanmonstar I have made the requested changes to this PR as per your recommendations. Just wanted to know if there is any other change to be implemented or if the PR is ready for merging. |
seanmonstar
reviewed
Sep 17, 2024
|
I have implemented the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds http2 server example to the website as mentioned in hyperium/hyper#3568