-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v0.12.0 #1740
chore: release v0.12.0 #1740
Conversation
537727b
to
269e9e1
Compare
Excited to get this out! Previously the breaking changes were sorted before the features, probably better to keep it that way? Also would be nice to sort features from roughly most to least impactful. Do we want to wait for #1727 which will also be breaking API? |
I would think it sounds good to wait for #1727 if possible. |
Pending hyperium/tonic#1740. DNM until its released. This lets us drop a few shims
[v1.8.8]: https://github.com/fullstorydev/grpcurl/releases/tag/v1.8.8 | ||
[proto]: https://github.com/grpc/grpc/blob/master/src/proto/grpc/reflection/v1/reflection.proto | ||
[grpcurl]: https://github.com/fullstorydev/grpcurl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of these link definitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they just get auto generated by the tool I use 🤷
269e9e1
to
9161713
Compare
Looking forward to the release! |
@djc Is this still waiting on something or is this ready to be released? Your comment seems to imply the latter but you're still listed as a pending reviewer. |
I pinged @LucioFranco out of band, but he had some time off. I only became a maintainer recently and want to make sure we're good for a release (and the release procedure). |
I can see that more PR merged during this period. Perhaps the CHANGELOG should be updated? |
Sorry for the delay everyone, we wanted to get one last thing into this breaking release and it wasn't ready before I had some vacation so ended up missing the the time to cut the release. Will be shipping it ASAP now that I am back. |
9161713
to
16b4076
Compare
Going to release |
Take your time, my man. Vacation time is important to prevent burn out. Hope you had a good one. Cheers 🍻 |
Pending hyperium/tonic#1740. DNM until its released. This lets us drop a few shims
* dependencies: update to tonic 0.12 Pending hyperium/tonic#1740. DNM until its released. This lets us drop a few shims * Use official * udpate fuzz * copyright * no clone needed
This adds an implementation of nar-bridge in Rust. Currently, only the GET parts are implemented. Contrary to the Go variant, this doesn't try to keep a mapping from nar hashes to root node in memory, it simply encodes the root node itself (stripped by its basename) into the URL. This pulls in a more recent version of axum than what we use in tonic, causing two versions of http and hyper, however dealing with `Body::from_stream` in axum 0.6 is much more annoying, and hyperium/tonic#1740 suggests this will be fixed soon. Change-Id: Ia4c2dbda7cd3fdbe47a75f3e33544d19eac6e44e Reviewed-on: https://cl.tvl.fyi/c/depot/+/11898 Autosubmit: flokli <[email protected]> Reviewed-by: Brian Olsen <[email protected]> Tested-by: BuildkiteCI
v0.12.0 (2024-06-20)
This breaking release updates tonic to the hyper
1.0
ecosystem and also updatesto prost
v0.13.0
.Features
Bug Fixes
BREAKING CHANGES
tonic
and crates updated to hyper 1.0 (Upgrade to Hyper 1.0 & Axum 0.7 #1670)tonic
and crates updated to prost 0.13 (feat: updateprost
tov0.13.0
#1779)tonic_reflection::server
is updated to use the generatedtonic_reflection::pb::v1
code.