chore(server): Set nodelay and tcp timeout on constructing TcpIncoming #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
set-nodelay-and-tcp-timeout-on-constructing-tcpincoming
branch
from
e8f057d
to
30ea9ec
Compare
tottoto
force-pushed
the
set-nodelay-and-tcp-timeout-on-constructing-tcpincoming
branch
from
30ea9ec
to
6e8af8b
Compare
tobz
reviewed
Nov 7, 2024
There was a problem hiding this comment.
I'm not sure this is a good idea.
I know some socket options can be set on a listener and will be inherited by the accepted sockets, but I couldn't find anything in the POSIX specification that implies that they should always be inherited, or which ones should be inherited.
Unless you have a reference that demonstrates this as a stable, long-term behavior (on the major operating systems, such as Linux and Windows), I think we should leave it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets nodelay and tcp timeout on constructing
TcpIncoming.