-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents/starknet): support routing ISM #5153
base: feat/starknet-duplicate
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5153 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, seems like we'll def need a deeper review of the starknet feature branch though
let ism = Box::new(h_starknet::StarknetRoutingIsm::new( | ||
conf, | ||
&locator, | ||
signer.unwrap(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that elsewhere they were unwrapping but can you pls not unwrap? and if it's easy, change the other places where they do this. If it seems like it'll take a while you can punt on changing it elsewhere as I assume we'll need to do a big review of things before considering this fully done
Would recommend .ok_or_else(|| eyre!("error message here")
or something
Description
domain_routing_ism
in the relayerDrive-by changes
Related issues
Backward compatibility
Yes
Testing
e2e