Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents/starknet): support routing ISM #5153

Open
wants to merge 4 commits into
base: feat/starknet-duplicate
Choose a base branch
from

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Jan 12, 2025

Description

  • enable the already implemented domain_routing_ism in the relayer
  • add routing ism over aggregation of message id and pausable ism to the e2e test
  • dry_run_verify uses to_padded_bytes instead for compatibility with encoding in other parts of the starknet integration.

Drive-by changes

Related issues

Backward compatibility

Yes

Testing

e2e

Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: ff3a8b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (2d4963c) to head (88ba5cf).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5153   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@aroralanuk aroralanuk changed the base branch from main to feat/starknet-duplicate January 23, 2025 10:08
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems like we'll def need a deeper review of the starknet feature branch though

let ism = Box::new(h_starknet::StarknetRoutingIsm::new(
conf,
&locator,
signer.unwrap(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that elsewhere they were unwrapping but can you pls not unwrap? and if it's easy, change the other places where they do this. If it seems like it'll take a while you can punt on changing it elsewhere as I assume we'll need to do a big review of things before considering this fully done

Would recommend .ok_or_else(|| eyre!("error message here") or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants