Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents/relayer): update metrics even if no new event is found #5178

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

aroralanuk
Copy link
Contributor

Description

  • Follow up to feat(relayer): relayer exposes latest tree index as metric #5074, the cursor_max_sequence(event_type="merkle_tree_insertion") will be used for the highest merkle index on a chain. The logic to update this metric has been moved to when checking for new logs so we can update the metrics even if new events are not found.
  • Renamed latest_leaf_index to latest_tree_insertion_index for clarity.

Related #5151

Drive-by changes

None

Related issues

Backward compatibility

Yes

Testing

e2e + Manual

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: a8d63c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (5f9a7c8) to head (a8d63c2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5178   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@aroralanuk aroralanuk enabled auto-merge January 15, 2025 15:15
@aroralanuk aroralanuk added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@tkporter tkporter added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
)

### Description

- Follow up to
#5074, the
cursor_max_sequence(event_type="merkle_tree_insertion") will be used for
the highest merkle index on a chain. The logic to update this metric has
been moved to when checking for new logs so we can update the metrics
even if new events are not found.
- Renamed `latest_leaf_index` to `latest_tree_insertion_index` for
clarity.

Related #5151


### Drive-by changes

None

### Related issues

- fixes  hyperlane-xyz/issues#1396


### Backward compatibility

Yes

### Testing

e2e + Manual
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 17, 2025
@aroralanuk aroralanuk removed this pull request from the merge queue due to a manual request Jan 17, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@paulbalaji paulbalaji added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@aroralanuk aroralanuk added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit d8eb4a8 Jan 20, 2025
42 checks passed
@aroralanuk aroralanuk deleted the kunal/update-seq-metrics-without-indexing branch January 20, 2025 19:35
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
### Description

- updated image tag to `62702d3-20250121-002648` to update
cursor_max_sequence behavior from #5178

### Drive-by changes

None

### Related issues

None

### Backward compatibility

Yes

### Testing

Deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants