Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement network deploy script with fork test #5200

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: implement network deploy script with fork test #5200

wants to merge 4 commits into from
+122 −1

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Jan 17, 2025 •
edited
Loading

Description

  • Deploys symbiotic network

symbioticfi/metadata-mainnet#44

Drive-by changes

None

Testing

Assertions in script after broadcast

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4a6513f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yorhodes yorhodes changed the title Implement network deploy script with fork test feat: implement network deploy script with fork test Jan 17, 2025
nambrot
nambrot reviewed Jan 17, 2025
View reviewed changes
solidity/script/avs/DeployNetwork.s.sol Outdated Show resolved Hide resolved
solidity/script/avs/DeployNetwork.s.sol Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (31c89a3) to head (4a6513f).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5200   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@yorhodes yorhodes marked this pull request as ready for review January 17, 2025 22:39
yorhodes
yorhodes commented Jan 22, 2025
View reviewed changes
solidity/foundry.toml
@@ -7,7 +7,7 @@ test = 'test'
cache_path = 'forge-cache'
allow_paths = ["../node_modules"]
solc_version = '0.8.22'
evm_version= 'paris'
evm_version= 'shanghai'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symbiotic contracts use PUSH0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot left review comments

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorhodes @nambrot