Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: zksync verification classes #5210

Open
wants to merge 344 commits into
base: main
Choose a base branch
from
Open

feat: zksync verification classes #5210

wants to merge 344 commits into from
+1,760 −306

Conversation

mshojaei-txfusion
Copy link
Collaborator

@mshojaei-txfusion mshojaei-txfusion commented Jan 20, 2025 •
edited by ljankovic-txfusion
Loading

Description

This PR adds support for ZKSync contract verification with custom compiler options. Key changes include:

  • Added ZKSyncContractVerifier class to handle ZKSync-specific contract verification
  • Extended PostDeploymentContractVerifier to support ZKSync explorer family
  • Added ZKSync-specific compiler options and types
  • Implemented constructor arguments retrieval for ZKSync contracts
  • Added utility functions for ZKSync contract verification

PR to feat/zksync-deployment-functions

Drive-by changes

  • Refactored contract verification classes to better support different types of verifications
  • Extracted common verification logic into BaseContractVerifier
  • Added verification delay times for different explorer families
  • Improved error handling and logging for verification processes

Related issues

N/A

Backward compatibility

Yes - These changes are backward compatible. The existing contract verification functionality for other chains refactored with same interface.

Testing

Build passing

ljankovic-txfusion and others added 30 commits October 31, 2024 16:33
@ljankovic-txfusion
fix: contract verification on warp deploy
1b737c5
@ljankovic-txfusion
feat: static ISM type & technical stack assertion
c72805b
@ljankovic-txfusion
perf: check for static ism compatibility
4e5ed79
@mortezashojaei
fix: cleanup lint issue
eee7d78
@mortezashojaei
minor: comment explains state of zksync explorers support
53042da
@mortezashojaei
refactor: verification delay based on explorer family
9e9baba
@mortezashojaei
improvement: replace if with assert
264b241
@ljankovic-txfusion
fix: test imports
3755332
@ljankovic-txfusion
fix: imports and assertion
915de97
@ljankovic-txfusion
chore: skip e2e zksync tests
07c3e64
@ljankovic-txfusion
minor: change
3b1e97f
@ljankovic-txfusion
fix: overrides no longer override contract.initialize
44ca8ef
@ljankovic-txfusion
fix: ExplorerFamily casing & /dist/evm/ -> /core-utils/evm/
b85b075
@ljankovic-txfusion
fix: dist/evm -> core-utils/evm in all tests
421071a
@ljankovic-txfusion
chore: reorg core exports, handing zksync json artifacts
b212311
@ljankovic-txfusion
chore: reduce yarn.lock diff
2006daf
@ljankovic-txfusion
fix: skip zksync typechain creation
f638c20
@ljankovic-txfusion
feat: Singe/MultiVM signer strategy
ba0d6ea
@ljankovic-txfusion
feat: Deployment strategies & refactoring
2bf349b
@ljankovic-txfusion
fix: e2e test working
9c43d1c
@ljankovic-txfusion
chore: add comments & minor refactoring
3602abd
@ljankovic-txfusion
chore: minor fixes
ce81b48
@ljankovic-txfusion
Merge remote-tracking branch 'origin-root/main'
ff2b4c9
@ljankovic-txfusion
Merge remote-tracking branch 'origin-root/main'
af97d7f
@ljankovic-txfusion
perf: removed unused code and refactoring
e4839a1
@ljankovic-txfusion
feat: masked pk, refactoring
4abd806
@ljankovic-txfusion
feat: MultiChainHandler support to extract chains from WarpCoreConfig…
188dced 
… file
@ljankovic-txfusion
chore: refactoring & adding comments
0b92c68
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/key-command
ea205dc
@ljankovic-txfusion
feat: relay command chain resolver strategy & refactoring
ac6d5c1
ljankovic-txfusion and others added 30 commits January 27, 2025 15:09
@ljankovic-txfusion
chore: update yarn.lock with ZKSync and dependency upgrades
21d3da3
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-solidity' into feat/…
e7e6e01 
…zksync-sdk-provider
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
c24cfa1 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
0693468 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
Merge branch 'hyperlane-xyz:main' into main
258d535
@ljankovic-txfusion
feat: Add ZKSync solidity support and restructure build artifacts
30d3a46
@ljankovic-txfusion
feat(zksync): introduce core ZKSync artifact management utilities
fd3cf3d
@ljankovic-txfusion
fix(zksync): update artifact comments for clarity on build output loc…
ad338f8 
…ations
@ljankovic-txfusion
chore: remove unnecessary blank line in exportBuildArtifact.sh
81aa61e
@ljankovic-txfusion
chore: update dependencies in yarn.lock and package.json
5c54ef1
@ljankovic-txfusion
refactor(zksync): simplify artifact utility functions
002b807
@ljankovic-txfusion
chore: update yarn.lock with ZKSync and dependency upgrades
1f19a12
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-solidity' into feat/…
8cfe00a 
…zksync-sdk-provider
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
ade32ef 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
a30c9fe 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
chore: move zksync-ethers to production dependencies
66082d0
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
ff8fc05 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
e241c38 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
Merge branch 'hyperlane-xyz:main' into main
db616cc
@ljankovic-txfusion
feat: Add ZKSync solidity support and restructure build artifacts
0ac64e3
@ljankovic-txfusion
feat(zksync): introduce core ZKSync artifact management utilities
0c66a13
@ljankovic-txfusion
fix(zksync): update artifact comments for clarity on build output loc…
2b4dc4f 
…ations
@ljankovic-txfusion
chore: remove unnecessary blank line in exportBuildArtifact.sh
a1bf8ee
@ljankovic-txfusion
chore: update dependencies in yarn.lock and package.json
119bb40
@ljankovic-txfusion
refactor(zksync): simplify artifact utility functions
bf3ff4a
@ljankovic-txfusion
chore: update yarn.lock with ZKSync and dependency upgrades
d84da15
@ljankovic-txfusion
feat: update ESLint configuration and add lint script in solidity/pac…
17cf30d 
…kage.json
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-solidity' into feat/…
874ab60 
…zksync-sdk-provider
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
58e2c32 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
2b2b1a3 
…' into feat/zksync-verification-classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshojaei-txfusion @ljankovic-txfusion @mortezashojaei @ltyu