Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate zksync on cli #5216

Open
wants to merge 307 commits into
base: main
Choose a base branch
from
Open

feat: integrate zksync on cli #5216

wants to merge 307 commits into from

Conversation

mshojaei-txfusion
Copy link
Collaborator

@mshojaei-txfusion mshojaei-txfusion commented Jan 20, 2025 •
edited by ljankovic-txfusion
Loading

Description

This PR adds ZKSync compatibility validation for core contract deployments:

  • Adds pre-deployment check to validate ISM compatibility with chain's technical stack
  • Integrates isIsmCompatible utility from SDK
  • Adds assertion handling for incompatible ISM configurations

PR to feat/integrate-zksync-on-sdk

Related issues

N/A

Backward compatibility

Yes - This change adds additional validation but does not modify existing deployment behavior for supported chains.

Testing

Passed build

mortezashojaei and others added 30 commits October 15, 2024 16:18
@mortezashojaei
fix: update hardat config type output directories
eb79bea
@mortezashojaei
fix: update chain technical stack with latest values
cff1960
@mortezashojaei
Merge remote-tracking branch 'origin/txfusion/sending-messages' into …
075f699 
…txfusion/sending-messages
@mortezashojaei
merge with main repo latest changes
dedaa34
@mortezashojaei
merge: latest main changes
52b221d
@mortezashojaei
minor: yarn fix
1c591a1
@mortezashojaei
fix: add zksync address on explorer health test
317f6d7
@ljankovic-txfusion
naming: core/artifacts to core/zksync-artifacts
2f4cc62
@ljankovic-txfusion
feat: blacklist static contracts from being deployed on zksync on `hy…
dec3ef4 
…perlane core deploy` command
@ljankovic-txfusion
test: e2e on zksync for warp read & apply
8cc652d
@ljankovic-txfusion
feat: migrating from ProtocolType to chain technical stack for zksync
29205fb
@ljankovic-txfusion
feat: checking core config for Aggregation ISM on zksync core deployment
fbc7c31
@mortezashojaei
Merge remote-tracking branch 'origin-root/main'
4f541e3
@mortezashojaei
merge: latest changes from root repo main
48c9b8c
@mortezashojaei
minor: cleanup
570084a
@ljankovic-txfusion
chore: reverting from workspace to npm versioning in package.json
014e959
@mortezashojaei
minor: cleanup
c459f50
@mortezashojaei
refactor: contract verification contracts
057eae0
@ljankovic-txfusion
fix: PackageVersioned import in Mailbox.sol
59bff45
@mortezashojaei
Merge branch 'feat/zksync-support' into improvement/verification
e26c969
@mortezashojaei
Merge remote-tracking branch 'origin-root/main'
f10e542
@mortezashojaei
merge: update with latest changes from root
3a0ceca
@mortezashojaei
Merge remote-tracking branch 'origin-root/main'
36e2b00
@mortezashojaei
Merge branch 'feat/zksync-support' into improvement/verification
d938378
@ljankovic-txfusion
fix: linting & refactoring
ece0885
@mortezashojaei
fix: file not found issue in verification
400009e
@mortezashojaei
feat: fix etherscan and support zksync etherscan
fecdf66
@mshojaei-txfusion
Merge pull request #3 from txfusion/improvement/zksync-support
e523e4e 
perf: Improvement/zksync-support
@mortezashojaei
Merge remote-tracking branch 'origin-root/main' into feat/zksync-support
4c3996d
@mortezashojaei
cleanup: remove unused imports
1927aea
ljankovic-txfusion and others added 30 commits January 22, 2025 16:01
@ljankovic-txfusion
refactor: rename Provider type to NetworkProvider for clarity in prox…
4befd65 
…y utilities
@ljankovic-txfusion
refactor: rename STATIC_ISM_TYPE to STATIC_ISM_TYPES for consistency …
3e3c6f5 
…in ISM type definitions
@ljankovic-txfusion
refactor: convert artifact handling functions to async for improved p…
12e2c9d 
…erformance
@ljankovic-txfusion
refactor: clean up whitespace in exportBuildArtifact script
ab346fb
@mshojaei-txfusion
Merge branch 'hyperlane-xyz:main' into main
1058872
@ljankovic-txfusion
feat: add prepublishOnly script to automate build and ZKSync processes
793a59b
@ljankovic-txfusion
Merge branch 'hyperlane-xyz:main' into main
bf4aa1b
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/core-zksync
3adda1d
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-sdk-provider
f7d4002
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/core-zksync' into feat/zksy…
d87f76e 
…nc-sdk-provider
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
541e650 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
466467f 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
Merge branch 'hyperlane-xyz:main' into main
878719b
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-compatibi…
d7d7171 
…lity-check
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-verificat…
d56e358 
…ion-classes
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-compatibi…
4040fa5 
…lity-check
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-sdk-provider
d714f81
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-deploymen…
4dfafc4 
…t-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
f363a46 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
42c2c15 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-verification-classes…
8b0a49e 
…' into feat/zksync-compatibility-check
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-compatibility-check'…
28c64c8 
… into feat/integrate-zksync-on-sdk
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/integrate-zksync-on-sdk' in…
22629d5 
…to feat/integrate-zksync-on-cli
@ljankovic-txfusion
Merge branch 'hyperlane-xyz:main' into main
a4cd60d
@ljankovic-txfusion
Merge remote-tracking branch 'origin/main' into feat/zksync-sdk-provider
436f8e3
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-sdk-provider' into f…
5ffeaf6 
…eat/zksync-deployment-functions
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-deployment-functions…
8d93ee6 
…' into feat/zksync-verification-classes
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-verification-classes…
a5ee211 
…' into feat/zksync-compatibility-check
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/zksync-compatibility-check'…
2522b94 
… into feat/integrate-zksync-on-sdk
@ljankovic-txfusion
Merge remote-tracking branch 'origin/feat/integrate-zksync-on-sdk' in…
dd22e6b 
…to feat/integrate-zksync-on-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@tkporter tkporter Awaiting requested review from tkporter

@aroralanuk aroralanuk Awaiting requested review from aroralanuk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshojaei-txfusion @mortezashojaei @ljankovic-txfusion @ltyu